Use v2.5.0 image in DaemonSet, add node selector for Windows

Author: mauriciopoppe

helm/README.md

@@ -110,12 +110,21 @@ helm upgrade ./helm/provisioner -f <path-to-your-values-file> <release-name>
 
 ### helm version  >= v3.0.0
 
-Install via helm template:
+Install by adding the repo as a Helm repo:
+
+```sh
+helm repo add sig-storage-local-static-provisioner https://kubernetes-sigs.github.io/sig-storage-local-static-provisioner
+helm template --debug sig-storage-local-static-provisioner/local-static-provisioner --version <version> --namespace <namespace> > local-volume-provisioner.generated.yaml
+# edit local-volume-provisioner.generated.yaml if necessary
+kubectl create -f local-volume-provisioner.generated.yaml
+```
+
+Or install by cloning the repo locally:
 
 ```console
 git clone --depth=1 https://github.com/kubernetes-sigs/sig-storage-local-static-provisioner.git
 helm template -f <path-to-your-values-file> <release-name> --namespace <namespace> ./helm/provisioner > local-volume-provisioner.generated.yaml
-edit local-volume-provisioner.generated.yaml if necessary
+# edit local-volume-provisioner.generated.yaml if necessary
 kubectl create -f local-volume-provisioner.generated.yaml
 ```
 

helm/provisioner/Chart.yaml

@@ -1,5 +1,5 @@
 apiVersion: v2
-name: local-volume-static-provisioner
+name: local-static-provisioner
 description: Helm chart for the SIG Storage Local Volume Static Provisioner.
 type: application
 version: 1.0.0

helm/provisioner/templates/daemonset_windows.yaml

@@ -34,6 +34,9 @@ spec:
 {{- end }}
       nodeSelector:
         kubernetes.io/os: windows
+{{- if .Values.daemonset.nodeSelectorWindows }}
+        {{ toYaml .Values.daemonset.nodeSelectorWindows | nindent 8 }}
+{{- end }}
       tolerations:
         # an empty key operator Exists matches all keys, values and effects
         # which meants that this will tolerate everything

helm/provisioner/values.yaml

@@ -113,7 +113,7 @@ daemonset:
   #
   # Defines Provisioner's image name including container registry.
   #
-  image: k8s.gcr.io/sig-storage/local-volume-provisioner:v2.4.0
+  image: registry.k8s.io/sig-storage/local-volume-provisioner:v2.5.0
   #
   # Defines Image download policy, see kubernetes documentation for available values.
   #
@@ -131,6 +131,7 @@ daemonset:
   # NodeSelector constraint for local-volume-provisioner scheduling to nodes.
   # Ref: https://kubernetes.io/docs/concepts/configuration/assign-pod-node/#nodeselector
   nodeSelector: {}
+  nodeSelectorWindows: {}
   #
   # If configured KubeConfigEnv will (optionally) specify the location of kubeconfig file on the node.
   #  kubeConfigEnv: KUBECONFIG