Skip to content

Fix editor footer spacing - #1614

Open
lekhanpro wants to merge 1 commit into
reframe-oss:mainfrom
lekhanpro:gssoc-509-tighten-editor-footer-layout
Open

Fix editor footer spacing#1614
lekhanpro wants to merge 1 commit into
reframe-oss:mainfrom
lekhanpro:gssoc-509-tighten-editor-footer-layout

Conversation

@lekhanpro

Copy link
Copy Markdown

Summary

  • move the full-height page shell to the home page wrapper
  • let the video editor size to its own content instead of reserving an extra viewport before the footer
  • keep the footer naturally pinned after the main content on short pages

Closes #509

Testing

  • git diff --check

Note: full dependency-based checks were not run locally because this clone has no node_modules and the local disk has insufficient free space for a dependency install.

@vercel

vercel Bot commented Jul 6, 2026

Copy link
Copy Markdown

@lekhanpro is attempting to deploy a commit to the magic-peach1's projects Team on Vercel.

A member of the Team first needs to authorize it.

@github-actions

github-actions Bot commented Jul 6, 2026

Copy link
Copy Markdown
Contributor

👋 Thanks for your PR, @lekhanpro!

Welcome to Reframe — a browser-based video editor built for everyone 🎬

🟠 GSSoC'26 PR detected — thanks for contributing under GirlScript Summer of Code 2026!

What happens next

  1. 🤖 Automated checks — build & TypeScript typecheck will run automatically
  2. Vercel preview — a preview deployment will be created (requires maintainer authorization for fork PRs)
  3. 👀 Code review — a maintainer will review your changes
  4. 🚀 Merge — once approved, your PR will be merged!

Quick checklist

  • PR title follows Conventional Commits (e.g. feat: add dark mode)
  • Linked the issue this PR closes (e.g. Closes #123)
  • Tested the changes locally (bun run dev)
  • Build passes (bun run build)

Useful links

Happy coding! 🎉

@github-actions github-actions Bot added the level:beginner Beginner level - 20 pts label Jul 6, 2026
@github-actions

github-actions Bot commented Jul 6, 2026

Copy link
Copy Markdown
Contributor

⚠️ PR Format Issues — @lekhanpro

Please fix the following before your PR can be reviewed:

  • ⚠️ Use a conventional PR title. Examples:
    • feat: add dark mode support
    • fix: resolve aria label missing on slider
    • docs: add deployment guide to README

Push new commits after fixing — this comment will update automatically.

📖 CONTRIBUTING.md

@github-actions github-actions Bot added type:bug Bug fix type:testing Testing gssoc'26 GirlScript Summer of Code 2026 labels Jul 6, 2026
@lekhanpro

Copy link
Copy Markdown
Author

This is ready for GSSoC review. The GitHub Actions checks are passing; the remaining Vercel status points to the project's Vercel authorization flow rather than a build failure from this patch.

@github-actions

Copy link
Copy Markdown
Contributor

👋 This PR has been inactive for 21 days. It will be automatically closed in 14 days if there's no further activity.

If you need help with this PR, please comment or ping a maintainer.
Make sure your branch is rebased onto main and all CI checks pass.

@github-actions github-actions Bot added the needs-fixes PR has issues that need to be fixed label Jul 28, 2026
@magic-peach magic-peach added the status:awaiting-review Clean PR waiting on a maintainer, not the author label Aug 14, 2026
@github-actions github-actions Bot removed the needs-fixes PR has issues that need to be fixed label Aug 17, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

gssoc'26 GirlScript Summer of Code 2026 level:beginner Beginner level - 20 pts status:awaiting-review Clean PR waiting on a maintainer, not the author type:bug Bug fix type:testing Testing

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug] Large empty vertical gap between editor panel and footer on all screen sizes

2 participants