Skip to content

Commit 9a845e8

Browse files
author
Ben Hillis
committed
add logging if setting code page fails
1 parent cc603bd commit 9a845e8

File tree

1 file changed

+4
-4
lines changed

1 file changed

+4
-4
lines changed

src/windows/common/svccommio.cpp

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -65,15 +65,15 @@ ConsoleInput::ConsoleInput(HANDLE Handle, DWORD SavedMode) : m_Handle(Handle), m
6565
TrySetConsoleMode(Handle, NewMode);
6666

6767
// Set UTF-8 code page
68-
SetConsoleCP(CP_UTF8);
68+
LOG_IF_WIN32_BOOL_FALSE(SetConsoleCP(CP_UTF8));
6969
}
7070

7171
ConsoleInput::~ConsoleInput()
7272
{
7373
if (m_Handle)
7474
{
7575
TrySetConsoleMode(m_Handle, m_SavedMode);
76-
SetConsoleCP(m_SavedCodePage);
76+
LOG_IF_WIN32_BOOL_FALSE(SetConsoleCP(m_SavedCodePage));
7777
}
7878
}
7979

@@ -115,15 +115,15 @@ ConsoleOutput::ConsoleOutput(wil::unique_hfile ConsoleHandle, DWORD SavedMode) :
115115
}
116116

117117
// Set UTF-8 code page
118-
SetConsoleOutputCP(CP_UTF8);
118+
LOG_IF_WIN32_BOOL_FALSE(SetConsoleOutputCP(CP_UTF8));
119119
}
120120

121121
ConsoleOutput::~ConsoleOutput()
122122
{
123123
if (m_ConsoleHandle)
124124
{
125125
TrySetConsoleMode(m_ConsoleHandle.get(), m_SavedMode);
126-
SetConsoleOutputCP(m_SavedCodePage);
126+
LOG_IF_WIN32_BOOL_FALSE(SetConsoleOutputCP(m_SavedCodePage));
127127
}
128128
}
129129

0 commit comments

Comments
 (0)