Skip to content

Commit 198f1fc

Browse files
authored
Removing benchmarking from PR triggers (#800)
The benchmarking workflow cannot run successfully on the PR as it requires access to secrets which are not available in PR contexts. This commit removes that trigger and adds a trigger on pushes to branches starting with "bench/" so that testing can be done before merging to main by those with write access.
1 parent fbedb31 commit 198f1fc

File tree

1 file changed

+6
-4
lines changed

1 file changed

+6
-4
lines changed

.github/workflows/benchmark.yml

Lines changed: 6 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -10,11 +10,13 @@ concurrency:
1010
on:
1111
schedule:
1212
- cron: "0 0 * * 1" # Runs every Monday at midnight UTC
13-
# Triggers the workflow on push or pull request events but only for the master branch
13+
# Triggers the workflow on push to main or any branch starting bench.
14+
# The bench/** branches can be used for test before merge any PR that
15+
# might regress performance.
1416
push:
15-
branches: [ main ]
16-
pull_request:
17-
branches: [ main ]
17+
branches:
18+
- 'main'
19+
- 'bench/**'
1820

1921
# Allows you to run this workflow manually from the Actions tab
2022
workflow_dispatch:

0 commit comments

Comments
 (0)