fix: request identity encoding for streamable HTTP#2650
Closed
he-yufeng wants to merge 1 commit into
Closed
Conversation
Author
|
Closing this during backlog cleanup. The python-sdk queue has too many open PRs, and this older/no-human-signal item is lower priority than the remaining PRs that have recent validation, review discussion, or clearer current value. I can reopen or refresh it if maintainers want this specific change. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Accept-Encoding: identityon streamable HTTP client requestsAcceptandContent-Typerequest headers overriding client defaultsFixes #2649.
To verify
uv run pytest tests/shared/test_streamable_http.py::test_streamable_http_client_mcp_headers_override_defaults tests/shared/test_streamable_http.py::test_streamable_http_client_preserves_custom_with_mcp_headers -q --basetemp .tmp/pytestuv run pytest tests/shared/test_streamable_http.py::test_streamable_http_client_json_response -q --basetemp .tmp/pytest-jsonuv run ruff check src/mcp/client/streamable_http.py tests/shared/test_streamable_http.pyuv run python -m py_compile src/mcp/client/streamable_http.py tests/shared/test_streamable_http.pygit diff --check