Skip to content

fix(mfdataarray): use integer indexed filenames #2704

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
wpbonelli merged 1 commit into from
Feb 4, 2026
Merged

fix(mfdataarray): use integer indexed filenames #2704

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions autotest/test_mf6_tas.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -134,6 +134,10 @@ def test_tas_set_all_data_external(function_tmpdir):
content = f.read()
assert "OPEN/CLOSE" in content
assert "INTERNAL" not in content
assert "tas_array_1.txt" in content
assert "tas_array_2.txt" in content

external_files = list(sim_ws.glob("*.txt"))
assert len(external_files) >= 2
external_files = sorted(sim_ws.glob("*tas_array_*.txt"))
assert len(external_files) == 2
assert external_files[0].name.endswith("tas_array_1.txt")
assert external_files[1].name.endswith("tas_array_2.txt")
7 changes: 2 additions & 5 deletions flopy/mf6/data/mfdataarray.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1790,7 +1790,7 @@ def store_as_external_file(

"""
# store each stress period in separate file(s)
for sp in self._data_storage.keys():
for idx, sp in enumerate(sorted(self._data_storage.keys()), start=1):
self._current_key = sp
layer_storage = self._get_storage_obj().layer_storage
if (
Expand All @@ -1799,10 +1799,7 @@ def store_as_external_file(
!= DataStorageType.external_file
):
fname, ext = os.path.splitext(external_file_path)
if DatumUtil.is_int(sp):
full_name = f"{fname}_{sp + 1}{ext}"
else:
full_name = f"{fname}_{sp}{ext}"
full_name = f"{fname}_{idx}{ext}"
super().store_as_external_file(
full_name,
layer,
Expand Down
Loading