Skip to content

Bug: outOfFocusTimeouts array grows unboundedly — cleared timeout ids never removed from array #8366

Description

@priyanshu1976

Did you clear cache before opening an issue?

  • I have cleared my cache

Is there an existing issue for this?

  • I have searched the existing open and closed issues

Does the issue happen when logged in?

Yes

Does the issue happen when logged out?

Yes

Does the issue happen in incognito mode when logged in?

Yes

Does the issue happen in incognito mode when logged out?

Yes

Issue details

Current Behavior

outOfFocusTimeouts in frontend/src/ts/states/test.ts accumulates timeout ids forever:

// states/test.ts:38-54
const outOfFocusTimeouts: (number | NodeJS.Timeout)[] = [];
...
} else {
  outOfFocusTimeouts.push(
    setTimeout(() => { set(val); }, 1000),
  );
}

Every unfocus event pushes a new id onto the array. clearTimeouts() (utils/misc.ts:148-153) only calls clearTimeout on each entry but never removes them from the array, so the array grows monotonically for the entire session. Long sessions with frequent alt-tabbing accumulate thousands of stale numeric ids (small but unnecessary retained memory, and the array scan in clearTimeouts grows linearly).

Expected Behavior

Remove consumed entries after clearing, e.g.:

export function clearTimeouts(timeouts: (number | NodeJS.Timeout)[]): void {
  timeouts.forEach((to) => clearTimeout(to));
  timeouts.length = 0;
}

or store only the latest timeout id, since scheduling a newer unfocus supersedes older pending ones anyway.

Steps To Reproduce

  1. Open devtools memory snapshot / add a breakpoint log on outOfFocusTimeouts.push.
  2. Blur/refocus the window repeatedly during tests.
  3. Array length increases without bound and is never reset.

Environment

  • OS: Any
  • Browser: Any
  • Found via source review of master @ 91bd24b

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions