From 7db8ff3c61b61ef9afebc55095b540923f49406b Mon Sep 17 00:00:00 2001 From: imamWahyudiz Date: Sat, 7 Nov 2026 02:26:23 +0700 Subject: [PATCH 1/3] fix(sdk): use unit {log_record} for otel.sdk.processor.log.queue.size Fixes #5888 --- .changelog/5888.fixed | 1 + .../sdk/_shared_internal/_processor_metrics.py | 4 ++-- opentelemetry-sdk/tests/logs/test_export.py | 10 ++++++++++ 3 files changed, 13 insertions(+), 2 deletions(-) create mode 100644 .changelog/5888.fixed diff --git a/.changelog/5888.fixed b/.changelog/5888.fixed new file mode 100644 index 00000000000..243404b36b1 --- /dev/null +++ b/.changelog/5888.fixed @@ -0,0 +1 @@ +`opentelemetry-sdk`: use unit `{log_record}` and update description for `otel.sdk.processor.log.queue.size` diff --git a/opentelemetry-sdk/src/opentelemetry/sdk/_shared_internal/_processor_metrics.py b/opentelemetry-sdk/src/opentelemetry/sdk/_shared_internal/_processor_metrics.py index aae2b14d967..450b735e387 100644 --- a/opentelemetry-sdk/src/opentelemetry/sdk/_shared_internal/_processor_metrics.py +++ b/opentelemetry-sdk/src/opentelemetry/sdk/_shared_internal/_processor_metrics.py @@ -106,8 +106,8 @@ def record_queue_size( queue_size_unit = "{span}" else: queue_size_name = OTEL_SDK_PROCESSOR_LOG_QUEUE_SIZE - queue_size_description = "The number of logs in the queue of a given instance of an SDK log processor." - queue_size_unit = "{log}" + queue_size_description = "The number of log records in the queue of a given instance of an SDK log processor." + queue_size_unit = "{log_record}" self._meter.create_observable_up_down_counter( queue_size_name, diff --git a/opentelemetry-sdk/tests/logs/test_export.py b/opentelemetry-sdk/tests/logs/test_export.py index f39a8606f96..ca9ce9822f5 100644 --- a/opentelemetry-sdk/tests/logs/test_export.py +++ b/opentelemetry-sdk/tests/logs/test_export.py @@ -754,6 +754,11 @@ def export_logs(_logs): queue_capacity_data_point.attributes["otel.component.name"].startswith("batching_log_processor/") ) self.assertEqual(metrics[2].name, "otel.sdk.processor.log.queue.size") + self.assertEqual(metrics[2].unit, "{log_record}") + self.assertEqual( + metrics[2].description, + "The number of log records in the queue of a given instance of an SDK log processor.", + ) queue_size_data_point = metrics[2].data.data_points[0] self.assertEqual(queue_size_data_point.value, 1) self.assertEqual( @@ -811,6 +816,11 @@ def export_logs(_logs): queue_capacity_data_point.attributes["otel.component.name"].startswith("batching_log_processor/") ) self.assertEqual(metrics[2].name, "otel.sdk.processor.log.queue.size") + self.assertEqual(metrics[2].unit, "{log_record}") + self.assertEqual( + metrics[2].description, + "The number of log records in the queue of a given instance of an SDK log processor.", + ) queue_size_data_point = metrics[2].data.data_points[0] self.assertEqual(queue_size_data_point.value, 0) self.assertEqual( From 7355c3a958c2b20026d0955d559b9c283cfd347e Mon Sep 17 00:00:00 2001 From: imamWahyudiz Date: Sat, 7 Nov 2026 13:07:14 +0700 Subject: [PATCH 2/3] chore: update changelog filename to match PR number 5893 --- .changelog/{5888.fixed => 5893.fixed} | 0 1 file changed, 0 insertions(+), 0 deletions(-) rename .changelog/{5888.fixed => 5893.fixed} (100%) diff --git a/.changelog/5888.fixed b/.changelog/5893.fixed similarity index 100% rename from .changelog/5888.fixed rename to .changelog/5893.fixed From 75b4db51e41a2b11bf353990e63ed30688f00c0f Mon Sep 17 00:00:00 2001 From: imamWahyudiz Date: Sat, 7 Nov 2026 18:29:08 +0700 Subject: [PATCH 3/3] style: format description line with ruff --- .../opentelemetry/sdk/_shared_internal/_processor_metrics.py | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/opentelemetry-sdk/src/opentelemetry/sdk/_shared_internal/_processor_metrics.py b/opentelemetry-sdk/src/opentelemetry/sdk/_shared_internal/_processor_metrics.py index 450b735e387..75f88a17cb7 100644 --- a/opentelemetry-sdk/src/opentelemetry/sdk/_shared_internal/_processor_metrics.py +++ b/opentelemetry-sdk/src/opentelemetry/sdk/_shared_internal/_processor_metrics.py @@ -106,7 +106,9 @@ def record_queue_size( queue_size_unit = "{span}" else: queue_size_name = OTEL_SDK_PROCESSOR_LOG_QUEUE_SIZE - queue_size_description = "The number of log records in the queue of a given instance of an SDK log processor." + queue_size_description = ( + "The number of log records in the queue of a given instance of an SDK log processor." + ) queue_size_unit = "{log_record}" self._meter.create_observable_up_down_counter(