Conversation
joelparkerhenderson
added a commit
to mssql-rust/mssql-rust
that referenced
this pull request
Aug 29, 2026
Mirrors tiberius-rs/tiberius#314. Lets a ColumnData already read from one row be bound straight back into a query parameter -- e.g. copying a value between statements, or generic code that already deals in ColumnData -- without round-tripping it through a concrete Rust type first. All four impls are trivial passthroughs (clone/self). Added a small unit test exercising all four traits' round trip. Verified: cargo check across all 6 CI feature combinations, cargo clippy --all-targets, cargo fmt --check, and cargo test --lib (153 passing) all pass. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_0156Di1tRRLsJK8ctU1AmAJr
MattJackson
referenced
this pull request
in MattJackson/tiberius-ng
Aug 29, 2026
Adapted from upstream #314 (author @LazyDope).
joelparkerhenderson
added a commit
to mssql-rust/mssql-rust
that referenced
this pull request
Aug 30, 2026
Mirrors tiberius-rs/tiberius#314. Lets a ColumnData already read from one row be bound straight back into a query parameter -- e.g. copying a value between statements, or generic code that already deals in ColumnData -- without round-tripping it through a concrete Rust type first. All four impls are trivial passthroughs (clone/self). Added a small unit test exercising all four traits' round trip. Verified: cargo check across all 6 CI feature combinations, cargo clippy --all-targets, cargo fmt --check, and cargo test --lib (153 passing) all pass. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_0156Di1tRRLsJK8ctU1AmAJr
This was referenced Sep 1, 2026
MattJackson
added a commit
that referenced
this pull request
Sep 3, 2026
MattJackson
added a commit
that referenced
this pull request
Sep 4, 2026
MattJackson
added a commit
that referenced
this pull request
Sep 6, 2026
MattJackson
added a commit
that referenced
this pull request
Sep 16, 2026
MattJackson
added a commit
that referenced
this pull request
Sep 24, 2026
Contributor
|
Included in #442 — shipped in tiberius v0.13.0. Thanks for this! Closing. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allows using ColumnData as parameters for queries, if you wanted to generically store various types of valid SQL data in one place and bind it directly instead of first converting out of ColumnData, which would of course just convert back to ColumnData as soon as it's put into the query bind. Instead you can just store ColumnData, and provide it to the bind method directly, without any converting back and forth since IntoSql just takes ownership of the ColumnData.
This also resolves my earlier issue of getting generic data from a row by name, however both of these solutions have their own merits by themselves.