Skip to content

Commit d03a8bc

Browse files
committed
checkWindowsDLLs: skip missing check if bundledDir has all DLLs
1 parent 7dfc6c0 commit d03a8bc

2 files changed

Lines changed: 10 additions & 9 deletions

File tree

mode/CppMode.jar

23 Bytes
Binary file not shown.

src/java/CppBuild.java

Lines changed: 10 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -658,10 +658,7 @@ private void checkWindowsDLLs(RunnerListener listener, File binary) throws Excep
658658

659659
// Bundled DLLs are in libs/windows-x64 -- copy them next to the binary
660660
File bundledDir = new File(runtimeDir.getParentFile(), "libs/windows-x64");
661-
javax.swing.JOptionPane.showMessageDialog(null,
662-
"bundledDir: " + bundledDir.getAbsolutePath() + "\nexists: " + bundledDir.exists() +
663-
"\nruntimeDir: " + runtimeDir.getAbsolutePath(),
664-
"CppMode Debug", javax.swing.JOptionPane.INFORMATION_MESSAGE);
661+
665662
listener.statusNotice("CppMode: bundledDir=" + bundledDir.getAbsolutePath() + " exists=" + bundledDir.exists());
666663
File binaryDir = new File(binary.getParent());
667664
binaryDir.mkdirs();
@@ -679,12 +676,16 @@ private void checkWindowsDLLs(RunnerListener listener, File binary) throws Excep
679676
}
680677
}
681678

682-
// Verify required DLLs are now present
679+
// If all required DLLs exist in bundledDir, we're good -- they were
680+
// either copied successfully or will be found via the bundled path.
681+
boolean allBundled = true;
682+
for (String dll : required)
683+
if (!new File(bundledDir, dll).exists()) { allBundled = false; break; }
684+
if (allBundled) return;
685+
// Bundled dir missing some DLLs -- report error
683686
java.util.List<String> missing = new java.util.ArrayList<>();
684-
for (String dll : required) {
685-
if (!new File(binaryDir, dll).exists() && !new File(bundledDir, dll).exists())
686-
missing.add(dll);
687-
}
687+
for (String dll : required)
688+
if (!new File(bundledDir, dll).exists()) missing.add(dll);
688689
if (missing.isEmpty()) return;
689690

690691
// DLLs missing from bundle -- this should not happen in a correct install

0 commit comments

Comments
 (0)