updates

Author: lrvideckis

library/data_structures_[l,r)/seg_tree_uncommon/kd_tree.hpp

@@ -1,7 +1,7 @@
 #pragma once
 using T = int64_t;
-const T unit = 0;
-T op(T a, T b) { return a + b; }
+const T unit = LLONG_MIN;
+T op(T a, T b) { return max(a, b); }
 template<int K> struct KD_SEG {
   int n;
   vector<KD_SEG<K - 1>> s;
@@ -10,7 +10,7 @@ template<int K> struct KD_SEG {
   void update(int p, auto... a) {
     p += n;
     s[p].update(a...);
-    for (p /= 2; p > 0; p /= 2)
+    for (; p /= 2;)
       s[p].pull(s[2 * p], s[2 * p + 1], a...);
   }
   T query(int l, int r, auto... a) {
@@ -25,7 +25,7 @@ template<int K> struct KD_SEG {
     int p, auto... a) {
     p += n;
     s[p].pull(left.s[p], right.s[p], a...);
-    for (p /= 2; p > 0; p /= 2)
+    for (; p /= 2;)
       s[p].pull(s[2 * p], s[2 * p + 1], a...);
   }
 };

tests/library_checker_aizu_tests/data_structures/kd_bit_and_tree.test.cpp

@@ -13,10 +13,8 @@ int main() {
     for (int j = 0; j < m; j++) {
       int c;
       cin >> c;
-      if (c) {
-	      bit.update(i, j, 1);
-	      tree.update(i, j, 1);
-      }
+      tree.update(i, j, c);
+      if (c) bit.update(i, j, 1);
     }
   }
   int res = 0;
@@ -25,10 +23,10 @@ int main() {
       int start = 0, end = min(n - i, m - j) + 1;
       while (start + 1 < end) {
         int mid = (start + end) / 2;
-	int sum = bit.query(i, i + mid, j, j + mid);
-	assert(sum == tree.query(i, i + mid, j, j + mid));
-        if (sum == 0)
-          start = mid;
+        int sum = bit.query(i, i + mid, j, j + mid);
+        assert(
+          (sum > 0) == tree.query(i, i + mid, j, j + mid));
+        if (sum == 0) start = mid;
         else end = mid;
       }
       res = max(res, start);