Test: Radically simplify integration test reference data

Remove all the computed indirection from the test fixtures.

The expected/reference values should be as plain as possible
so that it is easy to change things, and easy to review and
confirm how things are supposed to work, and to have high
confidence in the results when they arre passing.

Previously, the expected results were complicated and thus
presented their own source of potential bugs and require debugging.

Instead:

- Use object literals for the expected values.
- Use propEqual() for comparing actual with expected.
- Any tolerance or mutation is done in a single place, before
  the tests begin.

Author: Krinkle

test/fixtures/integration/jasmine.js

@@ -36,8 +36,8 @@ describe('suite with tests', function () {
   });
 });
 
-describe('outter suite', function () {
-  it('outter test', function () {
+describe('outer suite', function () {
+  it('outer test', function () {
     expect(true).toBeTruthy();
   });
 

test/fixtures/integration/mocha.js

@@ -36,14 +36,14 @@ describe('suite with tests', function () {
   });
 });
 
-describe('outter suite', function () {
+describe('outer suite', function () {
   describe('inner suite', function () {
     it('inner test', function () {
 
     });
   });
 
-  it('outter test', function () {
+  it('outer test', function () {
 
   });
 });

test/fixtures/integration/qunit.js

@@ -32,14 +32,14 @@ QUnit.test('should fail', function () {
   throw new Error('error');
 });
 
-QUnit.module('outter suite', function () {
+QUnit.module('outer suite', function () {
   QUnit.module('inner suite', function () {
     QUnit.test('inner test', function (assert) {
       assert.ok(true);
     });
   });
 
-  QUnit.test('outter test', function (assert) {
+  QUnit.test('outer test', function (assert) {
     assert.ok(true);
   });
 });

test/integration/adapters-run.js

@@ -19,7 +19,7 @@ function rerequire (file) {
  * against a default test fixture.
  */
 module.exports = {
-  Jasmine: function (attachListeners) {
+  Jasmine: function (collectData) {
     const Jasmine = rerequire('jasmine');
     const jasmine = new Jasmine();
 
@@ -46,45 +46,45 @@ module.exports = {
       jasmine.completionReporter.onComplete(function () {});
     }
     const jasmineRunner = new JsReporters.JasmineAdapter(jasmine);
-    attachListeners(jasmineRunner);
+    collectData(jasmineRunner);
 
     jasmine.execute();
   },
 
-  'QUnit (1.x)': function (attachListeners) {
+  'QUnit (1.x)': function (collectData) {
     // Legacy npm package name
     const QUnit = rerequire('qunitjs');
     global.QUnit = QUnit;
     QUnit.config.autorun = false;
 
     const qunitRunner = new JsReporters.QUnitAdapter(QUnit);
-    attachListeners(qunitRunner);
+    collectData(qunitRunner);
 
     rerequire(path.join(testDir, 'qunit.js'));
 
     QUnit.load();
   },
-  QUnit: function (attachListeners) {
+  QUnit: function (collectData) {
     // Get a reporter context independent of the integration test suite itself
     const QUnit = rerequire('qunit');
     global.QUnit = QUnit;
     QUnit.config.autorun = false;
 
     const qunitRunner = new JsReporters.QUnitAdapter(QUnit);
-    attachListeners(qunitRunner);
+    collectData(qunitRunner);
 
     rerequire(path.join(testDir, 'qunit.js'));
 
     QUnit.start();
   },
-  Mocha: function (attachListeners) {
+  Mocha: function (collectData) {
     const Mocha = rerequire('mocha');
     const mocha = new Mocha();
     mocha.addFile(path.join(testDir, 'mocha.js'));
 
     const mochaRunner = new JsReporters.MochaAdapter(mocha);
 
-    attachListeners(mochaRunner);
+    collectData(mochaRunner);
     mocha.run();
   }
 };