Commit d568577
committed
server,browsers: Promote bailout to error and fix multi file in Safari
Minor:
* browsers: Fix safari() bug when running multiple test files.
* browsers: Rename Headless Firefox => Firefox Headless.
* client: Set `window.qunit_config_reporters_html = false`.
* client: Add basic visual `<pre>` output in debug mode.
* server: Change clientId format from "client_1" to "client_S1_C1"
to make verbose logs more useful. This makes it obvious which
clients are for the same testFile, and thus ControlServer.
* qtap: De-duplicate browsers and test files.
Major:
* qtap,server: Streamline error handling and signal handling to avoid
errors going unhandled, bypassing teardown, or causing
the process to be stuck waiting for nothing.
In particular, "Could not open <file>" is now propagated to a
top-level error (e.g. run throws/rejects) rather than a test-level
"bail". This means we emit "error" instead of "result" or "finish",
and other tests are cancelled as well.
With this in place, other uncaught errors are now handled better
as well, such as errors from reporters.
* qtap: handle uncaught errors from reporters, which otherwise
cause emit() to throw. Provide a dedicated EventEmitter proxy
to improve attribution in the error message to a given reporter.
This is limited to "on" both because its simpler that way, and
because it protects our EventEmitter object from reporters
tampering with "emit" or "on".
* reporter: Flesh out more of the default reporter,
and refine the events we emit to ease the work of reporters.
In particular, promote all bailouts to first-class errors that
bubble up and cancel other clients. This way, reporters don't need
to deal with formatting bailout as assert failure or or numbering
test counts (i.e. Completed 0 tests, 0 failed.), and thus don't
receive a "finish" event.1 parent a44acc4 commit d568577
File tree
13 files changed
+781
-391
lines changed- bin
- src
- test
- fixtures
13 files changed
+781
-391
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
155 | 155 | | |
156 | 156 | | |
157 | 157 | | |
158 | | - | |
| 158 | + | |
159 | 159 | | |
160 | | - | |
| 160 | + | |
161 | 161 | | |
162 | | - | |
| 162 | + | |
163 | 163 | | |
164 | | - | |
| 164 | + | |
165 | 165 | | |
166 | | - | |
| 166 | + | |
| 167 | + | |
| 168 | + | |
| 169 | + | |
| 170 | + | |
167 | 171 | | |
168 | | - | |
169 | | - | |
170 | | - | |
171 | | - | |
172 | | - | |
173 | | - | |
174 | | - | |
175 | | - | |
176 | | - | |
| 172 | + | |
177 | 173 | | |
178 | | - | |
| 174 | + | |
| 175 | + | |
| 176 | + | |
179 | 177 | | |
180 | | - | |
| 178 | + | |
181 | 179 | | |
182 | | - | |
| 180 | + | |
| 181 | + | |
| 182 | + | |
| 183 | + | |
| 184 | + | |
| 185 | + | |
| 186 | + | |
| 187 | + | |
183 | 188 | | |
184 | | - | |
| 189 | + | |
185 | 190 | | |
186 | | - | |
187 | | - | |
188 | | - | |
189 | | - | |
| 191 | + | |
190 | 192 | | |
191 | 193 | | |
192 | 194 | | |
193 | | - | |
| 195 | + | |
194 | 196 | | |
195 | | - | |
| 197 | + | |
| 198 | + | |
| 199 | + | |
| 200 | + | |
196 | 201 | | |
197 | 202 | | |
198 | 203 | | |
199 | | - | |
| 204 | + | |
200 | 205 | | |
201 | | - | |
202 | | - | |
203 | | - | |
204 | | - | |
205 | | - | |
206 | | - | |
207 | | - | |
208 | | - | |
| 206 | + | |
| 207 | + | |
| 208 | + | |
| 209 | + | |
| 210 | + | |
| 211 | + | |
| 212 | + | |
| 213 | + | |
209 | 214 | | |
210 | | - | |
| 215 | + | |
211 | 216 | | |
212 | | - | |
| 217 | + | |
213 | 218 | | |
214 | | - | |
215 | | - | |
| 219 | + | |
216 | 220 | | |
217 | | - | |
| 221 | + | |
| 222 | + | |
218 | 223 | | |
219 | | - | |
| 224 | + | |
220 | 225 | | |
221 | | - | |
| 226 | + | |
222 | 227 | | |
223 | | - | |
224 | | - | |
| 228 | + | |
| 229 | + | |
| 230 | + | |
| 231 | + | |
| 232 | + | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
436 | 436 | | |
437 | 437 | | |
438 | 438 | | |
439 | | - | |
| 439 | + | |
440 | 440 | | |
441 | 441 | | |
442 | 442 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1 | 1 | | |
2 | 2 | | |
3 | 3 | | |
| 4 | + | |
| 5 | + | |
4 | 6 | | |
5 | 7 | | |
6 | 8 | | |
| |||
90 | 92 | | |
91 | 93 | | |
92 | 94 | | |
93 | | - | |
| 95 | + | |
| 96 | + | |
| 97 | + | |
| 98 | + | |
| 99 | + | |
| 100 | + | |
| 101 | + | |
| 102 | + | |
| 103 | + | |
| 104 | + | |
| 105 | + | |
| 106 | + | |
| 107 | + | |
| 108 | + | |
| 109 | + | |
| 110 | + | |
| 111 | + | |
| 112 | + | |
| 113 | + | |
| 114 | + | |
| 115 | + | |
| 116 | + | |
| 117 | + | |
| 118 | + | |
| 119 | + | |
94 | 120 | | |
95 | 121 | | |
96 | 122 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
25 | 25 | | |
26 | 26 | | |
27 | 27 | | |
28 | | - | |
| 28 | + | |
29 | 29 | | |
30 | 30 | | |
31 | 31 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
118 | 118 | | |
119 | 119 | | |
120 | 120 | | |
121 | | - | |
| 121 | + | |
122 | 122 | | |
123 | 123 | | |
124 | 124 | | |
| |||
164 | 164 | | |
165 | 165 | | |
166 | 166 | | |
167 | | - | |
| 167 | + | |
168 | 168 | | |
169 | 169 | | |
170 | 170 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
4 | 4 | | |
5 | 5 | | |
6 | 6 | | |
| 7 | + | |
7 | 8 | | |
8 | 9 | | |
9 | 10 | | |
10 | 11 | | |
| 12 | + | |
11 | 13 | | |
12 | 14 | | |
13 | 15 | | |
| |||
67 | 69 | | |
68 | 70 | | |
69 | 71 | | |
| 72 | + | |
70 | 73 | | |
71 | 74 | | |
72 | 75 | | |
| |||
81 | 84 | | |
82 | 85 | | |
83 | 86 | | |
| 87 | + | |
| 88 | + | |
| 89 | + | |
| 90 | + | |
| 91 | + | |
| 92 | + | |
| 93 | + | |
| 94 | + | |
84 | 95 | | |
85 | | - | |
| 96 | + | |
86 | 97 | | |
87 | 98 | | |
88 | 99 | | |
| |||
0 commit comments