Skip to content

Classify iosswitch headers as private - #58405

Closed
coado wants to merge 1 commit into
react:mainfrom
coado:export-D119171908
Closed

coado wants to merge 1 commit into
react:mainfrom
coado:export-D119171908

Conversation

@coado

@coado coado commented Sep 8, 2026

Copy link
Copy Markdown
Contributor

Summary:
Classify the Apple Fabric Switch C++ headers as private API. Strict API consumers now receive a hard error when including these implementation headers, while React Native builds continue to use them under RN_BUILDING.

Propagate the cxxstableapi dependency from the iosswitch Buck target so its exported guarded headers resolve PrivateGuard.h.

Changelog: [Internal]

Differential Revision: D119171908

Summary:
Classify the Apple Fabric Switch C++ headers as private API. Strict API consumers now receive a hard error when including these implementation headers, while React Native builds continue to use them under RN_BUILDING.

Propagate the cxxstableapi dependency from the iosswitch Buck target so its exported guarded headers resolve PrivateGuard.h.

Changelog: [Internal]

Differential Revision: D119171908
@meta-cla meta-cla Bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Sep 8, 2026
@meta-codesync

meta-codesync Bot commented Sep 8, 2026

Copy link
Copy Markdown

@coado has exported this pull request. If you are a Meta employee, you can view the originating Diff in D119171908.

@facebook-github-tools facebook-github-tools Bot added p: Software Mansion Partner: Software Mansion Partner p: Facebook Partner: Facebook labels Sep 8, 2026

@cortinico cortinico left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review automatically exported from Phabricator review in Meta.

@meta-codesync meta-codesync Bot closed this in 5dcbbae Sep 9, 2026
@meta-codesync meta-codesync Bot added the Merged This PR has been merged. label Sep 9, 2026
@meta-codesync

meta-codesync Bot commented Sep 9, 2026

Copy link
Copy Markdown

This pull request has been merged in 5dcbbae.

shashikant-panchal pushed a commit to shashikant-panchal/react-native that referenced this pull request Sep 10, 2026
Summary:
Pull Request resolved: react#58405

Classify the Apple Fabric Switch C++ headers as private API. Strict API consumers now receive a hard error when including these implementation headers, while React Native builds continue to use them under RN_BUILDING.

Propagate the cxxstableapi dependency from the iosswitch Buck target so its exported guarded headers resolve PrivateGuard.h.

Changelog: [Internal]

Reviewed By: cortinico

Differential Revision: D119171908

fbshipit-source-id: ba935899a990c52c243c6b1a6e80da3b7e1940f9
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Merged This PR has been merged. meta-exported p: Facebook Partner: Facebook p: Software Mansion Partner: Software Mansion Partner

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants