Resolve current React context from the captured host - #58406
Open
andrewdacenko wants to merge 1 commit into
Open
Resolve current React context from the captured host#58406andrewdacenko wants to merge 1 commit into
andrewdacenko wants to merge 1 commit into
Conversation
Summary: `ReactDelegate` selects its host when it is constructed, but `currentReactContext` previously re-read the process-wide architecture flag to decide which host to query. If those states disagreed, a delegate containing a `ReactHost` could incorrectly access its absent legacy host and crash. Resolve the context from the host captured by the delegate instead. Prefer `ReactHost` when present; otherwise return the context from an already initialized `ReactNativeHost`. The legacy path remains non-creating when no instance exists. Add focused coverage for bridgeless and legacy hosts, including a contradictory architecture flag and initialized, uninitialized, and absent legacy hosts. Changelog: [Android][Fixed] - Prevent `ReactDelegate.currentReactContext` from querying the wrong host when architecture state changes Differential Revision: D119096676
meta-cla
Bot
added
the
CLA Signed
|
@andrewdacenko has exported this pull request. If you are a Meta employee, you can view the originating Diff in D119096676. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
ReactDelegateselects its host when it is constructed, butcurrentReactContextpreviously re-read the process-wide architecture flag to decide which host to query. If those states disagreed, a delegate containing aReactHostcould incorrectly access its absent legacy host and crash.Resolve the context from the host captured by the delegate instead. Prefer
ReactHostwhen present; otherwise return the context from an already initializedReactNativeHost. The legacy path remains non-creating when no instance exists.Add focused coverage for bridgeless and legacy hosts, including a contradictory architecture flag and initialized, uninitialized, and absent legacy hosts.
Changelog:
[Android][Fixed] - Prevent
ReactDelegate.currentReactContextfrom querying the wrong host when architecture state changesDifferential Revision: D119096676