Parameter order for optional parameters in InvokableCommandInputAttributeRector

[florisluiten]

Bug Report

Subject	Details
Rector version	2.2.7

Using InvokableCommandInputAttributeRector, it seems that optional and required parameters are mixed depending on where they appear in the code. This may lead to a parameterlist that has optional parameters before required parameters.

Minimal PHP Code Causing Issue

rectorphp/rector-symfony#899

Expected Behaviour

Imo, the optional parameters should always be listed last.

[Jean85]

In my situation, this is automatically solved by OptionalParametersAfterRequiredRector. Do you expect that to be applied also when InvokableCommandInputAttributeRector is run separately?

[florisluiten]

Hm, had not thought about applying another rule to fix that. I suspect that would be a good workaround for the time being, thanks for the pointer.

I still think that it would be better if the InvokableCommandInputAttributeRector would place the arguments in the right order though :)

[Jean85]

What is "the right order" though? If those are command arguments (and not options) the order because it influences the CLI behavior...