Null type safety not working with jakarta.validation.constraints.NotNull

[thermcampos]

[provide a description of the issue]

Environment

• Operating System: Linux Ubuntu 22.04
• JDK version: 17.0.8 (Oracle GraalVM 17.0.8+9.1 build 17.0.8+9-LTS-jvmci-23.0-b14)
• Visual Studio Code version: 1.86.2
• Java extension version: v1.28.1

Steps To Reproduce

1. Create a method with org.springframework.lang.NonNull annotation
2. Calls that method with arguments annotated with jakarta.validation.constraints.NotNull
3. A yellow line shows up on the method call highlighting: Null type safety: The expression of type 'String' needs unchecked conversion to conform to '@NonNull String'Java(16778128)

[Please attach a sample project reproducing the error]
Here:
warnings-bug.zip

Please attach logs
Here:
warning-logs.log

Current Result

VS Code says it could be null, it may have null value.

Expected Result

No warnings at all, since it was annotated with NotNull;

Additional Informations

None

[snjeza]

@RMCampos you can try to add

org.eclipse.jdt.core.compiler.problem.nullUncheckedConversion=ignore

to <your_project>/.settings/org.eclipse.jdt.core.prefs

@fbricon @rgrunber We could set this property per default when null analysis is enabled.

[thermcampos]

@snjeza I have to projects inside the same root directory. Shall I put this on the root directory, or inside each project?

[snjeza]

@RMCampos You may want to take a look at Settings Global Preferences

[thermcampos]

@snjeza that worked! Thank you!

[agriffis]

Hi @snjeza, I'm wondering if you could elaborate on the following statement:

@fbricon @rgrunber We could set this property per default when null analysis is enabled.

Why would jdtls set that property when null analysis is enabled? Does nullUncheckedConversion no longer apply in that case?

Context: I'm using jdtls in a project with existing Eclipse settings, and trying to reconcile the changes that jdtls is making to those settings. See eclipse-jdtls/eclipse.jdt.ls#2655 (comment)