diff --git a/lib/singed/rack_middleware.rb b/lib/singed/rack_middleware.rb index bce1e2f..f267974 100644 --- a/lib/singed/rack_middleware.rb +++ b/lib/singed/rack_middleware.rb @@ -9,15 +9,11 @@ def initialize(app) end def call(env) - status, headers, body = if capture_flamegraph?(env) - flamegraph do - @app.call(env) - end + if capture_flamegraph?(env) + flamegraph { @app.call(env) } else @app.call(env) end - - [status, headers, body] end def capture_flamegraph?(env) diff --git a/spec/singed/middleware_spec.rb b/spec/singed/middleware_spec.rb new file mode 100644 index 0000000..ae547ec --- /dev/null +++ b/spec/singed/middleware_spec.rb @@ -0,0 +1,47 @@ +# frozen_string_literal: true + +describe Singed::RackMiddleware do + subject do + instance.call(env) + end + + let(:app) { ->(*) { [200, {"content-type" => "text/plain"}, ["OK"]] } } + let(:instance) { described_class.new(app) } + let(:env) { Rack::MockRequest.env_for("/", headers) } + let(:headers) { {} } + + before do + allow_any_instance_of(Singed::Flamegraph).to receive(:open) + end + + it "returns a proper rack response" do + linted_app = Rack::Lint.new(instance) + expect { linted_app.call(env) }.not_to raise_error + end + + it "does not capture a flamegraph by default" do + expect(instance).not_to receive(:flamegraph) + subject + end + + context "when enabled" do + before { allow(instance).to receive(:capture_flamegraph?).and_return(true) } + + it "captures a flamegraph" do + expect(instance).to receive(:flamegraph).and_call_original + subject + end + end + + describe "#capture_flamegraph?" do + subject { instance.capture_flamegraph?(env) } + + it { is_expected.to be false } + + context "when HTTP_X_SINGED is true" do + let(:headers) { {"HTTP_X_SINGED" => "true"} } + + it { is_expected.to be true } + end + end +end diff --git a/spec/singed_spec.rb b/spec/singed_spec.rb index 700bb6b..37db1bc 100644 --- a/spec/singed_spec.rb +++ b/spec/singed_spec.rb @@ -1,19 +1,12 @@ # frozen_string_literal: true -require "tempfile" - RSpec.describe Singed do around do |example| - original_output_directory = Singed.output_directory - Singed.output_directory = Dir.mktmpdir("singed-spec") original_enabled = Singed.enabled? - begin - example.run - ensure - Singed.output_directory = original_output_directory - Singed.enabled = original_enabled - Singed.instance_variable_set(:@current_flamegraph, nil) - end + example.run + ensure + Singed.enabled = original_enabled + Singed.instance_variable_set(:@current_flamegraph, nil) end describe ".start" do @@ -42,7 +35,6 @@ describe ".stop" do before do Singed.enabled = true - Singed.output_directory = Dir.mktmpdir("singed-spec") end it "returns nil when not profiling" do diff --git a/spec/spec_helper.rb b/spec/spec_helper.rb index 1850212..93d807f 100644 --- a/spec/spec_helper.rb +++ b/spec/spec_helper.rb @@ -15,8 +15,17 @@ # See https://rubydoc.info/gems/rspec-core/RSpec/Core/Configuration require "singed" +require "tmpdir" RSpec.configure do |config| + config.around do |example| + Dir.mktmpdir("singed-spec") do |dir| + Singed.output_directory = dir + example.run + end + ensure + Singed.output_directory = nil + end # rspec-expectations config goes here. You can use an alternate # assertion/expectation library such as wrong or the stdlib/minitest # assertions if you prefer. diff --git a/spec/support/sidekiq.rb b/spec/support/sidekiq.rb index 4634569..c813758 100644 --- a/spec/support/sidekiq.rb +++ b/spec/support/sidekiq.rb @@ -1,5 +1,4 @@ require "singed/sidekiq" -require "tempfile" RSpec.configure do |config| config.before(:suite) do @@ -16,14 +15,6 @@ ActiveJob::Base.queue_adapter = :sidekiq ActiveJob::Base.logger = Logger.new(nil) end - - config.around(:each, sidekiq: true) do |example| - orig_dir = Singed.output_directory - Singed.output_directory = Dir.mktmpdir("singed-sidekiq-spec") - example.run - ensure - Singed.output_directory = orig_dir - end end # Sidekiq doesn't invoke middlewares in inline testingmode, so we need to invoke it oursleves