Skip to content

Reorder impl restriction rendering and add bottom margin#157633

Open
CoCo-Japan-pan wants to merge 1 commit into
rust-lang:mainfrom
CoCo-Japan-pan:impl-restriction-render-fix
Open

Reorder impl restriction rendering and add bottom margin#157633
CoCo-Japan-pan wants to merge 1 commit into
rust-lang:mainfrom
CoCo-Japan-pan:impl-restriction-render-fix

Conversation

@CoCo-Japan-pan

@CoCo-Japan-pan CoCo-Japan-pan commented Jun 9, 2026 •
edited by rustbot
Loading

Copy link
Copy Markdown
Contributor

This PR moves the impl restriction rendering above the trait description.
It also adds an ⓘ marker, italicizes the text, and adds a bottom margin.
Tracking issue: #105077

before:
image

after:
image

r? @GuillaumeGomez
cc @Urgau @jhpratt

@rustbot

rustbot commented Jun 9, 2026

Copy link
Copy Markdown
Collaborator

Some changes occurred in HTML/CSS/JS.

cc @GuillaumeGomez, @lolbinarycat

@rustbot rustbot added A-rustdoc-js Area: Rustdoc's JS front-end S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. labels Jun 9, 2026
@rustbot rustbot added the T-rustdoc-frontend Relevant to the rustdoc-frontend team, which will review and decide on the web UI/UX output. label Jun 9, 2026
@GuillaumeGomez

GuillaumeGomez commented Jun 9, 2026

Copy link
Copy Markdown
Member

Looks all good to me, thanks!

@bors r+ rollup

@rust-bors

rust-bors Bot commented Jun 9, 2026

Copy link
Copy Markdown
Contributor

📌 Commit 656124d has been approved by GuillaumeGomez

It is now in the queue for this repository.

@rust-bors rust-bors Bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 9, 2026
GuillaumeGomez added a commit to GuillaumeGomez/rust that referenced this pull request Jun 9, 2026
@GuillaumeGomez
Rollup merge of rust-lang#157633 - CoCo-Japan-pan:impl-restriction-re…
0de87e0 
…nder-fix, r=GuillaumeGomez

Reorder `impl` restriction rendering and add bottom margin

This PR moves the `impl` restriction rendering above the trait description.
It also adds an ⓘ marker, italicizes the text, and adds a bottom margin.
Tracking issue: rust-lang#105077

before:
<img width="1108" height="651" alt="image" src="https://github.com/user-attachments/assets/520d95cf-a648-44e7-8036-e453cfbdf569" />

after:
<img width="1085" height="671" alt="image" src="https://github.com/user-attachments/assets/84493e56-6227-433b-93d0-4fcbe28ac00c" />

r? @GuillaumeGomez
cc @Urgau @jhpratt
@GuillaumeGomez GuillaumeGomez mentioned this pull request Jun 9, 2026
Closed
GuillaumeGomez added a commit to GuillaumeGomez/rust that referenced this pull request Jun 9, 2026
@GuillaumeGomez
Rollup merge of rust-lang#157633 - CoCo-Japan-pan:impl-restriction-re…
ef4c026 
…nder-fix, r=GuillaumeGomez

Reorder `impl` restriction rendering and add bottom margin

This PR moves the `impl` restriction rendering above the trait description.
It also adds an ⓘ marker, italicizes the text, and adds a bottom margin.
Tracking issue: rust-lang#105077

before:
<img width="1108" height="651" alt="image" src="https://github.com/user-attachments/assets/520d95cf-a648-44e7-8036-e453cfbdf569" />

after:
<img width="1085" height="671" alt="image" src="https://github.com/user-attachments/assets/84493e56-6227-433b-93d0-4fcbe28ac00c" />

r? @GuillaumeGomez
cc @Urgau @jhpratt
@GuillaumeGomez GuillaumeGomez mentioned this pull request Jun 9, 2026
Closed
rust-bors Bot pushed a commit that referenced this pull request Jun 9, 2026
@bors
Auto merge of #157663 - GuillaumeGomez:rollup-Iwi31Tb, r=GuillaumeGomez
492c116 
Rollup of 10 pull requests

Successful merges:

 - #157335 (bootstrap: Handle dotted table keys when parsing bootstrap.toml)
 - #157503 (Disable `tests/debuginfo/pretty-std.rs` `OsString` cdb check)
 - #148183 (rustdoc: Test & document `test_harness` code block attribute)
 - #156067 (Fix async drop glue for Box<T>)
 - #156399 (fix improper ctypes in Znext solver)
 - #157410 (Implement rustc_public::CrateDef{,Type} for FieldDef)
 - #157605 (Arg splat experiment - syntax impl)
 - #157630 (Add multibyte JSON diagnostic regression test)
 - #157633 (Reorder `impl` restriction rendering and add bottom margin)
 - #157642 (Report duplicate relaxed bounds during ast lowering)
GuillaumeGomez added a commit to GuillaumeGomez/rust that referenced this pull request Jun 9, 2026
@GuillaumeGomez
Rollup merge of rust-lang#157633 - CoCo-Japan-pan:impl-restriction-re…
671dfc0 
…nder-fix, r=GuillaumeGomez

Reorder `impl` restriction rendering and add bottom margin

This PR moves the `impl` restriction rendering above the trait description.
It also adds an ⓘ marker, italicizes the text, and adds a bottom margin.
Tracking issue: rust-lang#105077

before:
<img width="1108" height="651" alt="image" src="https://github.com/user-attachments/assets/520d95cf-a648-44e7-8036-e453cfbdf569" />

after:
<img width="1085" height="671" alt="image" src="https://github.com/user-attachments/assets/84493e56-6227-433b-93d0-4fcbe28ac00c" />

r? @GuillaumeGomez
cc @Urgau @jhpratt
@GuillaumeGomez GuillaumeGomez mentioned this pull request Jun 9, 2026
Closed
jhpratt added a commit to jhpratt/rust that referenced this pull request Jun 9, 2026
@jhpratt
Rollup merge of rust-lang#157633 - CoCo-Japan-pan:impl-restriction-re…
77b7c73 
…nder-fix, r=GuillaumeGomez

Reorder `impl` restriction rendering and add bottom margin

This PR moves the `impl` restriction rendering above the trait description.
It also adds an ⓘ marker, italicizes the text, and adds a bottom margin.
Tracking issue: rust-lang#105077

before:
<img width="1108" height="651" alt="image" src="https://github.com/user-attachments/assets/520d95cf-a648-44e7-8036-e453cfbdf569" />

after:
<img width="1085" height="671" alt="image" src="https://github.com/user-attachments/assets/84493e56-6227-433b-93d0-4fcbe28ac00c" />

r? @GuillaumeGomez
cc @Urgau @jhpratt
@jhpratt jhpratt mentioned this pull request Jun 9, 2026
Closed
rust-bors Bot pushed a commit that referenced this pull request Jun 9, 2026
@bors
Auto merge of #157679 - jhpratt:rollup-Y7coMpH, r=jhpratt
b954412 
Rollup of 18 pull requests

Successful merges:

 - #152852 (Remove driver_lint_caps)
 - #157166 (Change type of async context parameter after state transform.)
 - #157335 (bootstrap: Handle dotted table keys when parsing bootstrap.toml)
 - #157503 (Disable `tests/debuginfo/pretty-std.rs` `OsString` cdb check)
 - #157571 (Remove ProcMacro enum from proc macro ABI)
 - #148183 (rustdoc: Test & document `test_harness` code block attribute)
 - #153847 (Fix marker trait winnowing depending on impl order)
 - #156067 (Fix async drop glue for Box<T>)
 - #156399 (fix improper ctypes in Znext solver)
 - #157338 (Make `Literal::byte_character_value` work with bytes as well)
 - #157410 (Implement rustc_public::CrateDef{,Type} for FieldDef)
 - #157605 (Arg splat experiment - syntax impl)
 - #157630 (Add multibyte JSON diagnostic regression test)
 - #157633 (Reorder `impl` restriction rendering and add bottom margin)
 - #157642 (Report duplicate relaxed bounds during ast lowering)
 - #157652 (fix doc for unicode normalization faq on `casefold` APIs)
 - #157661 (Update to ar_archive_writer v0.5.2)
 - #157668 (Add test for matches in `rustc_must_match_exhaustively`)

Failed merges:

 - #157670 (Rename `errors.rs` file to `diagnostics.rs` (4/N))
jhpratt added a commit to jhpratt/rust that referenced this pull request Jun 9, 2026
@jhpratt
Rollup merge of rust-lang#157633 - CoCo-Japan-pan:impl-restriction-re…
6911137 
…nder-fix, r=GuillaumeGomez

Reorder `impl` restriction rendering and add bottom margin

This PR moves the `impl` restriction rendering above the trait description.
It also adds an ⓘ marker, italicizes the text, and adds a bottom margin.
Tracking issue: rust-lang#105077

before:
<img width="1108" height="651" alt="image" src="https://github.com/user-attachments/assets/520d95cf-a648-44e7-8036-e453cfbdf569" />

after:
<img width="1085" height="671" alt="image" src="https://github.com/user-attachments/assets/84493e56-6227-433b-93d0-4fcbe28ac00c" />

r? @GuillaumeGomez
cc @Urgau @jhpratt
@jhpratt jhpratt mentioned this pull request Jun 9, 2026
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@GuillaumeGomez GuillaumeGomez GuillaumeGomez approved these changes

@jhpratt jhpratt jhpratt approved these changes

Assignees

@GuillaumeGomez GuillaumeGomez

Labels

A-rustdoc-js Area: Rustdoc's JS front-end S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. T-rustdoc-frontend Relevant to the rustdoc-frontend team, which will review and decide on the web UI/UX output.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@CoCo-Japan-pan @rustbot @GuillaumeGomez @jhpratt