Skip to content

wasm32-wasip1-threads: Correct llvm target name#157644

Open
kolayne wants to merge 1 commit into
rust-lang:mainfrom
kolayne:patch-1
Open

wasm32-wasip1-threads: Correct llvm target name#157644
kolayne wants to merge 1 commit into
rust-lang:mainfrom
kolayne:patch-1

Conversation

@kolayne

@kolayne kolayne commented Jun 9, 2026

Copy link
Copy Markdown

Intends to fix #131007, a problem with cross-compiling Rust+C++ to wasm32-wasip1-threads: clang will be told to compile for --target=wasm32-wasi, which it interprets as wasm32-wasip1, which is not compatible with wasm32-wasip1-threads.

I wonder if there might be any compatibility issue or something depending on the old incorrect name...

@rustbot

rustbot commented Jun 9, 2026

Copy link
Copy Markdown
Collaborator

These commits modify compiler targets.
(See the Target Tier Policy.)

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Jun 9, 2026
@rustbot

rustbot commented Jun 9, 2026

Copy link
Copy Markdown
Collaborator

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @mu001999 (or someone else) some time within the next two weeks.

Please see the contribution instructions for more information. Namely, in order to ensure the minimum review times lag, PR authors and assigned reviewers should ensure that the review label (S-waiting-on-review and S-waiting-on-author) stays updated, invoking these commands when appropriate:

  • @rustbot author: the review is finished, PR author should check the comments and take action accordingly
  • @rustbot review: the author is ready for a review, this PR will be queued again in the reviewer's queue
Why was this reviewer chosen?

The reviewer was selected based on:

  • Owners of files modified in this PR: compiler
  • compiler expanded to 73 candidates
  • Random selection from 20 candidates

@mu001999

mu001999 commented Jun 9, 2026

Copy link
Copy Markdown
Member

r? alexcrichton

@rustbot rustbot assigned alexcrichton and unassigned mu001999 Jun 9, 2026
@alexcrichton

Copy link
Copy Markdown
Member

Apologies but I no longer maintain this wasm target, so I'd prefer it if someone else took a look at this.

r? compiler

@rustbot rustbot assigned adwinwhite and unassigned alexcrichton Jun 9, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

wasm32_wasip1_threads's llvm_target is mistake

5 participants