Skip to content

Clarify in the dev guide what is expected from a PR #4865

@rami3l

Description

@rami3l

Problem you are trying to solve

As reported by @Cloud0310, there has been some unspoken rules in effect when reviewing PRs like #4861. Those could involve but are not limited to the following domains:

  • The naming of variables
  • The format of import sections
  • The ordering of declarations
  • The splitting of commits

The lack of clarity in the reviewing process could lead to repeated churn in the reviewing process.

Solution you'd like

Clearly describe what is expected from a regular pull request to the rustup project in the developer guide, which should make it easier for us to onboard new regular contributors.

Notes

No response

Metadata

Metadata

Assignees

No one assigned

    Type

    No type
    No fields configured for issues without a type.

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions