MSVC build is broken

[mikeoliphant]

The latest code changes broke the build on Visual Studio because of the use of the "restrict" keyword.

[James-Morrell]

@mikeoliphant I'm having a similar issue, using your PR helped to the point, but I'm still failing "dlfcn.h" imports in "allocation_tracking.h". Any ideas what's going on? It's seems like a gnu only thing.

[mikeoliphant]

@James-Morrell I assume you are building with the default cmake config?

It looks like something that is being used for running tests. If you don't need the tests, you could just comment them out of the CMakeLists.txt.

As for the root of the problem, I think it will require some changes to that code, as the MSVC equivalent has a different API.

[James-Morrell]

Thanks for the reply @mikeoliphant,

Yes I'm using the default cmake config, commenting out those tests the build looks fine.
Looking a little further into what dlfcn.h is for, it looks like it's an override "free, malloc and realloc" to count allocations & frees. Not sure if you can do that using MSVC? (though I'm probably wrong!)

[mikeoliphant]

The functionality is there - it just doesn't use the same API.

It looks like there is a wrapper library for MSVC that provides the POSIX API, though:

https://github.com/dlfcn-win32/dlfcn-win32

Not sure how important having this functionality work in MSVC really is. Depending on what you are doing, you are probably better off with your own build configuration instead of using the default one here.

[James-Morrell]

For my use it's not important, more just trying to help make the project a bit more windows friendly.
Thanks for your response, I'll look at dlfcn-win32.