Skip to content

Commit 3c4768b

Browse files
committed
test(desktop): assert the lane on LogoShell directly, not via the sweep
Cursor found the one shell the enumeration could go silent on. `LogoShell` sits under the `app/(landing)/` prefix allowlist, and this PR replaced its `min-h-screen` with `desktop-title-bar-page` — so stripping the reservation also strips its last viewport token and the sweep stops watching it. Doubly exempt, and it is the shell behind not-found, the interfaces shell (chat, resume), the desktop handoff and the public-file gates. `AuthShell` already had a dedicated assertion; `LogoShell` now has the same. Verified by stripping its reservation: caught now, silent before. This is the documented enumeration limit made concrete rather than a new class of problem — a root leaves the sweep when it stops claiming the viewport. The general fix is still to treat route entry points as window roots, which pulls in seven unassessed pages and belongs in its own change.
1 parent 4e3ee22 commit 3c4768b

1 file changed

Lines changed: 11 additions & 0 deletions

File tree

apps/sim/app/_shell/desktop-title-bar-surfaces.test.ts

Lines changed: 11 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -36,6 +36,7 @@ const workspaceChrome = read(
3636
const sidebar = read('../workspace/[workspaceId]/w/components/sidebar/sidebar.tsx')
3737
const globalStyles = read('../_styles/globals.css')
3838
const desktopTitleBar = read('../_shell/desktop-title-bar.tsx')
39+
const logoShell = read('../(landing)/components/logo-shell/logo-shell.tsx')
3940
const pageHeaderBar = read('../../components/page-header-bar.ts')
4041
const resourceHeader = read(
4142
'../workspace/[workspaceId]/components/resource/components/resource-header/resource-header.tsx'
@@ -57,6 +58,16 @@ describe('desktop title-bar surface audit', () => {
5758
expect(authLayout).toContain('<AuthShell>')
5859
})
5960

61+
it('keeps the lane on the shell the non-auth desktop surfaces wear', () => {
62+
// `LogoShell` backs not-found, the interfaces shell (chat, resume), the desktop handoff
63+
// and the public-file gates. It needs its own assertion rather than relying on the
64+
// enumeration: it sits under the `app/(landing)/` prefix allowlist, and stripping its
65+
// reservation would also strip its last viewport token, so the sweep would fall silent
66+
// on the very shell those surfaces depend on.
67+
expect(logoShell).toContain('desktop-title-bar-page')
68+
expect(logoShell).toContain('<DesktopTitleBarLane />')
69+
})
70+
6071
it('mounts a real drag surface across login and workspace title-bar lanes', () => {
6172
const dragRegion = globalStyles.match(/\.desktop-window-drag-region\s*\{([^}]*)\}/)?.[1]
6273

0 commit comments

Comments
 (0)