refactor(tables): keep CSV coercion in import switch

Author: j15z

apps/sim/lib/table/column-types/extension-points.test.ts

@@ -8,18 +8,13 @@ import {
   valueForTypeConversion,
   wouldExceedColumnTypeLimit,
 } from '@/lib/table/column-types'
-import { coerceValue } from '@/lib/table/import'
 import type { ColumnDefinition } from '@/lib/table/types'
 
 const definition = COLUMN_TYPE_REGISTRY.string
 const originalMaxPerTable = definition.maxPerTable
-const originalCoerceImport = definition.coerceImport
 const originalValueForConversion = definition.valueForConversion
 
-function restoreOptionalProperty(
-  key: 'maxPerTable' | 'coerceImport' | 'valueForConversion',
-  value: unknown
-) {
+function restoreOptionalProperty(key: 'maxPerTable' | 'valueForConversion', value: unknown) {
   if (value === undefined) {
     Reflect.deleteProperty(definition, key)
     return
@@ -29,7 +24,6 @@ function restoreOptionalProperty(
 
 afterEach(() => {
   restoreOptionalProperty('maxPerTable', originalMaxPerTable)
-  restoreOptionalProperty('coerceImport', originalCoerceImport)
   restoreOptionalProperty('valueForConversion', originalValueForConversion)
 })
 
@@ -82,12 +76,4 @@ describe('column type extension points', () => {
       )
     ).toBeNull()
   })
-
-  it('lets a type own CSV import coercion', () => {
-    Object.assign(definition, {
-      coerceImport: (value: unknown) => `imported:${String(value)}`,
-    })
-
-    expect(coerceValue('raw', 'string')).toBe('imported:raw')
-  })
 })

apps/sim/lib/table/column-types/index.ts

@@ -14,7 +14,6 @@ export * from '@/lib/table/column-types/registry'
 export type {
   CoerceResult,
   ColumnCellEditor,
-  ColumnImportCoerceOptions,
   ColumnType,
   ColumnTypeDefinition,
   TypeSpecificColumnKey,

apps/sim/lib/table/column-types/types.ts

@@ -68,10 +68,6 @@ export type TypeSpecificColumnKey = (typeof TYPE_SPECIFIC_COLUMN_KEYS)[number]
 /** Result of coercing a raw value toward a column's declared type. */
 export type CoerceResult = { ok: true; value: JsonValue } | { ok: false }
 
-export interface ColumnImportCoerceOptions extends NormalizeDateCellOptions {
-  currencyCode?: string
-}
-
 export interface ColumnTypeDefinition {
   readonly id: ColumnType
 
@@ -170,9 +166,6 @@ export interface ColumnTypeDefinition {
     context?: NormalizeDateCellOptions
   ): CoerceResult
 
-  /** CSV-specific coercion when invalid input must survive for row-level validation. */
-  coerceImport?(value: unknown, options?: ColumnImportCoerceOptions): Exclude<JsonValue, Date>
-
   /** Source-owned normalization applied before checking or rewriting a type conversion. */
   valueForConversion?(value: JsonValue, target: ColumnDefinition): JsonValue
 

apps/sim/lib/table/import.ts

@@ -15,7 +15,6 @@ import type { Options as CsvParseOptions } from 'csv-parse'
 import { OrchestrationError } from '@/lib/core/orchestration/types'
 import { getColumnId } from '@/lib/table/column-keys'
 import type { ColumnType } from '@/lib/table/column-types'
-import { columnTypeById } from '@/lib/table/column-types'
 import { parseCurrencyInput } from '@/lib/table/currency'
 import { type NormalizeDateCellOptions, normalizeDateCellValue } from '@/lib/table/dates'
 import type { ColumnDefinition, RowData, TableSchema } from '@/lib/table/types'
@@ -482,8 +481,6 @@ export function coerceValue(
   options?: NormalizeDateCellOptions & { currencyCode?: string }
 ): string | number | boolean | null | Record<string, unknown> | unknown[] {
   if (value === null || value === undefined || value === '') return null
-  const definition = columnTypeById(colType)
-  if (definition.coerceImport) return definition.coerceImport(value, options)
 
   switch (colType) {
     case 'number': {