Skip to content

fix: Keeps note active even if it's not on the current view when comi… #2979

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
antsgar merged 1 commit into from
Feb 5, 2026
Merged

fix: Keeps note active even if it's not on the current view when comi… #2979

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/web/src/javascripts/Components/CommandPalette/CommandPalette.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -177,7 +177,7 @@ function CommandPalette() {
return
}
if (decryptedItem instanceof SNNote) {
void application.navigationController.selectHomeNavigationView()
application.itemListController.keepActiveItemOpenForSystemView(decryptedItem.uuid)
void application.itemListController.selectItemUsingInstance(decryptedItem, true)
} else if (decryptedItem instanceof FileItem) {
void application.filesController.handleFileAction({
Expand Down
18 changes: 18 additions & 0 deletions packages/web/src/javascripts/Controllers/ItemList/ItemListController.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -89,6 +89,7 @@ export class ItemListController
includeTrashed: false,
includeProtected: true,
}
private keepActiveItemOpenUuid: UuidString | undefined
webDisplayOptions: WebDisplayOptions = {
hideTags: true,
hideDate: false,
Expand Down Expand Up @@ -499,6 +500,10 @@ export class ItemListController
!activeItemExistsInUpdatedResults && !isSearching && this.navigationController.isInAnySystemView()

if (closeBecauseActiveItemDoesntExistInCurrentSystemView) {
if (activeItem && activeItem.uuid === this.keepActiveItemOpenUuid) {
log(LoggingDomain.Selection, 'shouldCloseActiveItem false due to keepActiveItemOpenUuid')
return false
}
log(LoggingDomain.Selection, 'shouldCloseActiveItem closePreviousItemWhenSwitchingToFilesBasedView')
return true
}
Expand Down Expand Up @@ -941,6 +946,7 @@ export class ItemListController
}

handleTagChange = async (userTriggered: boolean) => {
this.clearKeepActiveItemOpenUuid()
const activeNoteController = this.getActiveItemController()
if (activeNoteController instanceof NoteViewController && activeNoteController.isTemplateNote) {
this.closeItemController(activeNoteController)
Expand Down Expand Up @@ -1196,11 +1202,23 @@ export class ItemListController
}
}

if (this.keepActiveItemOpenUuid && uuid !== this.keepActiveItemOpenUuid) {
this.clearKeepActiveItemOpenUuid()
}

return {
didSelect: this.selectedUuids.has(uuid),
}
}

keepActiveItemOpenForSystemView = (noteUuid: UuidString): void => {
this.keepActiveItemOpenUuid = noteUuid
}

private clearKeepActiveItemOpenUuid(): void {
this.keepActiveItemOpenUuid = undefined
}

selectItem = async (
uuid: UuidString,
userTriggered?: boolean,
Expand Down
Loading