From ac8fca4cd01e40ca0445411912faccb26ea221c9 Mon Sep 17 00:00:00 2001
From: Kevin Thornton <krthornt@uci.edu>
Date: Tue, 5 May 2026 04:52:53 -0700
Subject: [PATCH] refactor: deprecate function redundant w/standard iterator
 ops

---
 src/trees/tree.rs   | 1 +
 tests/test_trees.rs | 5 ++---
 2 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/src/trees/tree.rs b/src/trees/tree.rs
index a0f9115a..b74496f7 100644
--- a/src/trees/tree.rs
+++ b/src/trees/tree.rs
@@ -156,6 +156,7 @@ impl<'treeseq> Tree<'treeseq> {
     }
 
     /// Return all roots as a vector.
+    #[deprecated(since = "0.16.2", note = "Use Tree::roots + Iterator::collect")]
     pub fn roots_to_vec(&self) -> Vec<NodeId> {
         self.roots().collect::<Vec<_>>()
     }
diff --git a/tests/test_trees.rs b/tests/test_trees.rs
index 362464ba..e10efd88 100644
--- a/tests/test_trees.rs
+++ b/tests/test_trees.rs
@@ -166,10 +166,9 @@ fn test_iterate_tree_seq_with_one_tree() {
         assert_eq!(tree.parents(-1_i32).count(), 0);
         assert_eq!(tree.children(-1_i32).count(), 0);
 
-        let roots = tree.roots_to_vec();
-        for r in roots.iter() {
+        for r in tree.roots() {
             let mut num_children = 0;
-            for _ in tree.children(*r) {
+            for _ in tree.children(r) {
                 num_children += 1;
             }
             assert_eq!(num_children, 2);