Fix IRC mirror timeout when relaying messages#917
Open
Grimpper wants to merge 2 commits into
Open
Conversation
* zulip/integrations/bridge_with_irc/irc_mirror_backend.py (fresh_session): New procedure. Ensure forked processes have a clean client to ensure they don't share the SSL sockets of the parent.
This change was originally proposed by Sharlatan Hellseher: https://codeberg.org/guix/guix/pulls/7418#issuecomment-12239616 * zulip/integrations/bridge_with_irc/irc-mirror.py: Rename file to 'irc_mirror.py' to make it importable as a Python module. * zulip/integrations/bridge_with_irc/irc_mirror.py: Introduce `main' entry point so it can be used as a setuptools console script entry point. * zulip/setup.py: Register 'zulip-irc-bridge' as a console script so it's installed as part of the package output.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: The IRC mirror times out when relaying IRC messages to Zulip due to SSL
socket sharing between parent and child processes after forking with
'mp.Process'.
How did you test this PR?
I've ran the mirror connected to a small IRC room and verified that the messages
where correctly relayed back and forth between the Zulip Cloud Guix instance and
the IRC room. I've used the following command:
Self-review checklist
(variable names, code reuse, readability, etc.).
Communicate decisions, questions, and potential concerns.
Individual commits are ready for review (see commit discipline).
Completed manual review and testing of the following: