refactoring: Message bus types #63
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR refactors the message bus type system by separating type definitions from concrete implementations. The CommandBus, EventBus, and QueryBus type aliases now reference the more general Dispatcher protocol rather than the specific Bus protocol, while the factory functions continue to return the concrete Bus implementations. Additionally, the secretstorage dependency is updated from version 3.4.0 to 3.4.1.
- Changed type aliases to use the
Dispatcherprotocol for greater flexibility - Refactored dependency injection setup to use anonymous factory functions
- Updated
secretstoragefrom 3.4.0 to 3.4.1
Reviewed Changes
Copilot reviewed 1 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| uv.lock | Updated secretstorage dependency to version 3.4.1 |
| cq/_core/message.py | Refactored message bus types to use Dispatcher protocol and restructured dependency injection |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.