Skip to content

Update workflows to fix node 20 deprecation and update golangci-lint-action version and config#595

Open
scottisloud wants to merge 26 commits intomainfrom
scoot/fix/ci-node-version-bump
Open

Update workflows to fix node 20 deprecation and update golangci-lint-action version and config#595
scottisloud wants to merge 26 commits intomainfrom
scoot/fix/ci-node-version-bump

Conversation

@scottisloud
Copy link
Copy Markdown
Contributor

@scottisloud scottisloud commented May 6, 2026

Overview

This PR:

  • Updates actions/checkout and actions/setup-go to v6, upping Node dependency to Node 24.
  • Updates golangci-lint-action to v9 and golangci version to 2.12.
  • Migrates the golangci config to conform to version 2
  • Removes deprecated linters.

Type of change

  • Created a new plugin
  • Improved an existing plugin
  • Fixed a bug in an existing plugin
  • Improved contributor utilities or experience

Related Issue(s)

  • Resolves: OS-140
  • Resolves: OS-141
  • Resolves: OS-145

How To Test

Changelog

  • Updates the following actions:
    • actions/checkout v4 -> v6
    • actions/setup-go v4 -> v6
    • golangci/golangci-lint-action v3 -> v9
    • DeterminateSystems/nix-installer-action main -> v22
    • DeterminateSystems/magic-nix-cache-action main -> v13
  • Updated Makefile with new version of golangci-lint
  • Updated .golangci.yml to conform to version 2 of the config file spec
  • Disabled linters newly recognizing existing errors (to be re-enabled and detected errors fixed in a future PR)

@scottisloud scottisloud self-assigned this May 6, 2026
Copy link
Copy Markdown

@JillRegan JillRegan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a few comments (2 not in scope of this ticket but think we should update anyways). Besides that everything else looks good!

Comment thread .github/workflows/test.yaml Outdated
Comment thread .github/workflows/update-flake-dependencies.yml Outdated
Comment thread .github/workflows/check-flake.yml Outdated
@scottisloud
Copy link
Copy Markdown
Contributor Author

scottisloud commented May 7, 2026

Some things out of scope for this PR:

  • update-flake-dependencies workflow will continue to error on gh api --method PUT /repos/1Password/shell-plugins/contents/$FILE_TO_COMMIT \ (likely due to expired OP_BOT_TOKEN)
  • Fixes to golangci-lint-action revealed linting issues in existing code. Those linters have been temporarily disabled and need to be re-enabled once the issues are fixed.

@scottisloud scottisloud requested a review from JillRegan May 7, 2026 20:06
@scottisloud scottisloud changed the title Update action/checkout and action/setup-go to Node 24-friendly versions OS-141 Update workflows to fix node 20 deprecation and update golangci-lint-action version and config May 7, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants