Add suppressions to run tests with sanitizers#940
Conversation
tmadlener
left a comment
There was a problem hiding this comment.
Very nice, thank you.
Since any given build will only ever have either an Address or a Thread sanitizer enabled could the setup code in cmake be simplified and only define a PODIO_SANITIZER_LIBRARY variable so that the pre-loading part could be done with less logic, effectively something along the lines of
if (ARG_PYTHON AND PODIO_SANITIZER_LIBRARY)
list(APPPEND test_environment "LD_PRELOAD=${PODIO_SANITIZER_LIBRARY}:$ENV{LD_PRELOAD}"
endif()Looking at the suppression files it looks like all of them are outside of podio? Could we thus say that #884 is fixed with this?
Co-authored-by: Thomas Madlener <thomas.madlener@desy.de>
Yes, actually I didn't see that there was an issue for that 😃 |
tmadlener
left a comment
There was a problem hiding this comment.
Thanks again for this. I really like that we can now run more tests with the sanitizers.
BEGINRELEASENOTES
ENDRELEASENOTES
For Clang 19 with ubsan what I did is to ignore almost every test since they all fail. I propose to just keep ignoring them and once a LCG stack with a more modern Clang appears then we can see since I can not reproduce locally with Clang 21. As a next step maybe someone can start to check the suppressions one by one and either report them or fix them...