fix(filesystem): overflow-safe bounds check in IOMemReader::pread#5262
Open
lgritz wants to merge 1 commit into
Open
fix(filesystem): overflow-safe bounds check in IOMemReader::pread#5262lgritz wants to merge 1 commit into
lgritz wants to merge 1 commit into
Conversation
IOMemReader::pread guarded its memcpy with `size + size_t(offset) > m_buf.size()`. For a large or negative offset, that addition wraps around size_t and can compare as in-bounds, skipping both the error path and the size clamp, so the memcpy reads past (or before) the buffer. Assisted-by: Claude Code / Claude Opus 4.8 Signed-off-by: Larry Gritz <lg@larrygritz.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
IOMemReader::pread guarded its memcpy with
size + size_t(offset) > m_buf.size(). For a large or negative offset, that addition wraps around size_t and can compare as in-bounds, skipping both the error path and the size clamp, so the memcpy reads past (or before) the buffer.Assisted-by: Claude Code / Claude Opus 4.8