Skip to content

build: fix certain clang varieties warning about giflib headers #5263

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
lgritz wants to merge 1 commit into
base: main
Choose a base branch
from
+6 −0
Open

build: fix certain clang varieties warning about giflib headers #5263

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions src/gif.imageio/gifinput.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,13 @@
#include <memory>
#include <vector>

// Prevent a conflict between gif_lib.h's reallocarray declaration (no
// exception spec) and glibc's stdlib.h version (noexcept/__THROW). Clang
// treats the mismatch as a hard error in C++ mode. We rename it away here
// since gifinput.cpp never calls reallocarray directly.
#define reallocarray giflib_reallocarray_private_
#include <gif_lib.h>
#undef reallocarray

#include <OpenImageIO/filesystem.h>
#include <OpenImageIO/imageio.h>
Expand Down
Loading