fix(build): fix EMBEDPLUGINS=0, make many build options env-override#5272
Open
lgritz wants to merge 1 commit into
Open
fix(build): fix EMBEDPLUGINS=0, make many build options env-override#5272lgritz wants to merge 1 commit into
lgritz wants to merge 1 commit into
Conversation
Change several build-time options from `option()` to our `set_option()`, which mostly has the effect of allowing them to be overridden by environment variables of the same name, which is really handy for CI variants. In the process, realized that we had some real problems with handling of EMBEDPLUGINS=0, it probably hasn't worked properly for years and went unnoticed because the one CI job variant that was trying to test EMBEDPLUGINS=0 actually *was not* because it was trying to do it by setting the environment variable, unaware that it could not be used to set the option until this patch. So there is a bit of cmake and linkage fixing that needed to be done to get it squared away. Assisted-by: Claude Code / opus-4.8 Signed-off-by: Larry Gritz <lg@larrygritz.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change several build-time options from
option()to ourset_option(), which mostly has the effect of allowing them to be overridden by environment variables of the same name, which is really handy for CI variants.In the process, realized that we had some real problems with handling of EMBEDPLUGINS=0, it probably hasn't worked properly for years and went unnoticed because the one CI job variant that was trying to test EMBEDPLUGINS=0 actually was not because it was trying to do it by setting the environment variable, unaware that it could not be used to set the option until this patch. So there is a bit of cmake and linkage fixing that needed to be done to get it squared away.
Assisted-by: Claude Code / opus-4.8