fix(bmp): validate scanline file position before reading#5274
Merged
Conversation
read_native_scanline computed the scanline's file position as m_bmp_header.offset + y * m_padded_scanline_size and seeked there without checking it against the file size. A corrupt header (bogus pixel-data offset or scanline size) can place that position far outside the file. Assisted-by: Claude Code / Claude Opus 4.8 Signed-off-by: Larry Gritz <lg@larrygritz.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
read_native_scanline computed the scanline's file position as m_bmp_header.offset + y * m_padded_scanline_size and seeked there without checking it against the file size. A corrupt header (bogus pixel-data offset or scanline size) can place that position far outside the file.
Assisted-by: Claude Code / Claude Opus 4.8