fix(raw): apply LibRaw memory cap before unpack to prevent OOM#5275
Open
lgritz wants to merge 1 commit into
Open
fix(raw): apply LibRaw memory cap before unpack to prevent OOM#5275lgritz wants to merge 1 commit into
lgritz wants to merge 1 commit into
Conversation
open_raw set imgdata.rawparams.max_raw_memory_mb *after* calling m_processor->unpack(), so LibRaw's allocation cap never protected the unpack step -- which is exactly where LibRaw allocates the raw image buffer. A corrupt raw file claiming huge dimensions could therefore allocate unbounded and OOM (showing up on the fuzzer as a 0-length crash artifact from an out-of-memory trip rather than a normal reproducer). Move the max_raw_memory_mb assignment to immediately after open_file succeeds, before unpack(), so the cap (default 2048 MB) actually bounds the allocation. LibRaw then fails the file cleanly instead of OOMing. Assisted-by: Claude Code / Claude Opus 4.8 Signed-off-by: Larry Gritz <lg@larrygritz.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
open_raw set imgdata.rawparams.max_raw_memory_mb after calling m_processor->unpack(), so LibRaw's allocation cap never protected the unpack step -- which is exactly where LibRaw allocates the raw image buffer. A corrupt raw file claiming huge dimensions could therefore allocate unbounded and OOM (showing up on the fuzzer as a 0-length crash artifact from an out-of-memory trip rather than a normal reproducer).
Move the max_raw_memory_mb assignment to immediately after open_file succeeds, before unpack(), so the cap (default 2048 MB) actually bounds the allocation. LibRaw then fails the file cleanly instead of OOMing.
Assisted-by: Claude Code / Claude Opus 4.8