Add design spec for C++17 migration#96
Merged
Merged
Conversation
joshbainbridge
force-pushed
the
cpp-17-migration
branch
2 times, most recently
from
06763e0 to
24d753f
Compare
joesfer
reviewed
Apr 28, 2026
joshbainbridge
force-pushed
the
cpp-17-migration
branch
2 times, most recently
from
0d9eb5c to
5f7ae7c
Compare
The project currently requires a binary/header-only install split due to C++14 lacking inline variables. This causes user-facing complexity with three extra CMake options and conditional compilation in bntables.h. Add a design document covering the migration plan from C++14 to C++17. This includes replacing constexpr/extern table patterns with inline constexpr, removing the OPENQMC_ENABLE_BINARY build machinery, updating documentation, and assessing NVCC compatibility risks. Assisted-by: Amp:claude-opus-4.6 Signed-off-by: Josh Bainbridge <josh.bainbridge@gmail.com>
joshbainbridge
force-pushed
the
cpp-17-migration
branch
from
5f7ae7c to
f78408e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The project currently requires a binary/header-only install split due to C++14 lacking inline variables. This causes user-facing complexity with three extra CMake options and conditional compilation in bntables.h. #86
Add a design document covering the migration plan from C++14 to C++17. This includes replacing constexpr/extern table patterns with inline constexpr, removing the OPENQMC_ENABLE_BINARY build machinery, and updating documentation.
For easier reading, you can enable the formatted display using this option on the Files changed tab:
