-
Notifications
You must be signed in to change notification settings - Fork 5
feat: add razorpay #15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Summary of ChangesHello @bajrangCoder, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request significantly enhances the platform's monetization capabilities by integrating Razorpay as a new payment gateway for web-based plugin purchases. It provides a complete end-to-end solution, from a user-friendly "Buy" button on the client-side to robust server-side APIs for secure transaction processing, payment verification, and webhook handling. The underlying database schema has been extended to support user-specific purchase records across different payment providers, ensuring that once a plugin is bought, it's permanently linked to the user's account for seamless access and download. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request introduces Razorpay integration to allow users to purchase plugins via the web. The changes are comprehensive, including a new client-side checkout component, backend APIs for creating and verifying Razorpay orders, and database schema updates to support web purchases. The implementation correctly handles security aspects like payment signature verification and uses webhooks for robustness. I've identified a few areas for improvement related to error handling, client-side logic robustness, and code duplication on the server side.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request introduces Razorpay as a payment gateway for purchasing plugins, a significant feature enhancement. The implementation covers both client-side checkout flow and a robust, secure server-side implementation with order creation, verification, and webhook handling. The database schema is updated accordingly with a migration script, and existing Google Play payment flows are correctly integrated to allow for cross-platform purchase recognition.
My review has identified a critical security vulnerability in the webhook signature verification that must be addressed. I've also included suggestions for improving user experience and making the database migration script more robust. Overall, this is a well-structured contribution, and with the recommended changes, it will be a solid addition to the platform.
ENV to be Updated before Merger.
PG_KEY_IDPG_KEY_SECRETPG_WEBHOOK_SECRET