Fix linking for legacy Windows#41
Open
icanhasmath wants to merge 1 commit into
Open
Conversation
Author
|
Added as a local patch for now - let's make sure this gets into future releases. |
Use Windows-specific library names for png and bz2, and skip sharpyuv when building for 32-bit Windows where it is not available to link. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
icanhasmath
force-pushed
the
6.2.2.9-Windows
branch
from
e42c9ee to
f2abeb1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes native linking for legacy Windows builds in
setup.py:libpng(png) andlibbz2(bz2).sharpyuvwhen building for 32-bit Windows, where it is not available to link against.Notes
All three changes only diverge from default behavior on Windows. In particular, the 32-bit skip is guarded by
sys.platform == "win32"so non-Windows 32-bit builds (e.g. 32-bit Linux/macOS) still linksharpyuvas before.🤖 Generated with Claude Code