feat(spawn): add --model flag for per-session model override#2117
Open
exuan wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What & why
ao spawnhad no way to set the model for a single session — the modelwas resolved only from project/role
agentConfig.model, so every sessionin a project shared one model. This adds a
--model <name>flag toao spawnthat overrides the model for that one spawn.Resolution precedence:
--model> roleagentConfig.model> projectagentConfig.model. The agent plugins already forward the resolvedconfig.modelto the underlying CLI as--model, so no plugin changesare needed; this PR only wires the spawn flag through to
resolveAgentSelection.Changes
--model <name>option onao spawnSessionSpawnConfig.modelthreaded toresolveAgentSelection({ spawnModelOverride })spawnModelOverridetakes precedence over role/project model inresolveAgentSelectionBackward compatibility
When
--modelis omitted, model resolution is unchanged.How to test
pnpm buildandpnpm typecheckpass for core and cliao spawn --helpshows the--modelflagIssue
Addresses the per-session (
ao spawn --model) part of #2116.