This repository was archived by the owner on Feb 27, 2020. It is now read-only.
Fixed incorrectly identifying get_magic_quotes_runtime as deprecated#52
Open
mheesters wants to merge 1 commit intoAlexia:masterfrom
Open
Fixed incorrectly identifying get_magic_quotes_runtime as deprecated#52mheesters wants to merge 1 commit intoAlexia:masterfrom
mheesters wants to merge 1 commit intoAlexia:masterfrom
Conversation
I'm getting results like these:
```
/var/www/something/FileByteStream.php
deprecatedFunctions
Line 42: if (function_exists('get_magic_quotes_runtime') && @get_magic_quotes_runtime() == 1) {
```
It looks like the script falsely identifies `get_magic_quotes_runtime` as being a deprecated function.
It's not: https://www.php.net/manual/en/function.get-magic-quotes-runtime.php whereare magic_quotes_runtime is indeed deprecated: https://www.php.net/manual/en/function.magic-quotes-runtime.php
I've extented the regex so that the target shouldn't be preceded by a underscore.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'm getting results like these:
It looks like the script falsely identifies
get_magic_quotes_runtimeas being a deprecated function.It's not: https://www.php.net/manual/en/function.get-magic-quotes-runtime.php whereare magic_quotes_runtime is indeed deprecated: https://www.php.net/manual/en/function.magic-quotes-runtime.php
I've extented the regex so that the target shouldn't be preceded by a underscore.