Conversation
justonedev1
force-pushed
the
OCTRL-346
branch
from
78908b9 to
bfa4f7e
Compare
teo
previously approved these changes
Dec 12, 2024
justonedev1
force-pushed
the
OCTRL-346
branch
from
bfa4f7e to
54ca5f8
Compare
knopers8
reviewed
Dec 12, 2024
core/core.go
Outdated
| defer ecsmetrics.StopGolangMetrics() | ||
| defer monitoring.Stop() | ||
|
|
||
| log.Infof("Everything initiated Listening on control port: %d", viper.GetInt("controlPort")) |
Collaborator
There was a problem hiding this comment.
i don't think operators care about which ports are being listened on. imho, you could consider setting it to info/support.
knopers8
approved these changes
Dec 12, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is adding http endpoint to be scraped by other tools (eg. Telegraf). Apart from mechanism to create metrics endpoint I also added mechanism to publish golang internal metrics.
P.S.: I changed this to a draft, so we can discuss it before merging.