Skip to content

[PWGDQ] Change: collisionID now from reducedeventinfo not track1 - #17386

Open
amikals wants to merge 1 commit into
AliceO2Group:masterfrom
amikals:dielectron-jets
Open

[PWGDQ] Change: collisionID now from reducedeventinfo not track1#17386
amikals wants to merge 1 commit into
AliceO2Group:masterfrom
amikals:dielectron-jets

Conversation

@amikals

@amikals amikals commented Aug 9, 2026

Copy link
Copy Markdown
Contributor

Running the JE framework on output from tableReader or dqEfficiency would sometimes fail because of unsorted dielectron indexing.

@github-actions github-actions Bot added the pwgdq label Aug 9, 2026
@github-actions github-actions Bot changed the title Change: collisionID now from reducedeventinfo not track1 [PWGDQ] Change: collisionID now from reducedeventinfo not track1 Aug 9, 2026
@github-actions

github-actions Bot commented Aug 9, 2026

Copy link
Copy Markdown

O2 linter results: ❌ 378 errors, ⚠️ 161 warnings, 🔕 9 disabled

@iarsene
iarsene enabled auto-merge (squash) August 10, 2026 12:01
@alibuild

Copy link
Copy Markdown
Collaborator

Error while checking build/O2Physics/code-check for e8ca434 at 2026-08-10 16:17:

## sw/BUILD/O2Physics-code-check-latest/log
--
========== List of issues found ==========
++ echo 'Found 14 errors and 0 warnings.'
Found 14 errors and 0 warnings.
++ [[ 14 -gt 0 ]]
++ cat /sw/BUILD/36cbfa3dcf5372180bc988a0260f01f6b98f96e5/O2Physics-code-check/errors.txt
PWGDQ/Tasks/dqEfficiency_withAssoc.cxx:595:30: error: do not use static_cast to downcast from a base to a derived class; use dynamic_cast instead [cppcoreguidelines-pro-type-static-cast-downcast,-warnings-as-errors]
PWGDQ/Tasks/dqEfficiency_withAssoc.cxx:918:29: error: do not use static_cast to downcast from a base to a derived class; use dynamic_cast instead [cppcoreguidelines-pro-type-static-cast-downcast,-warnings-as-errors]
PWGDQ/Tasks/dqEfficiency_withAssoc.cxx:3461:29: error: do not use static_cast to downcast from a base to a derived class; use dynamic_cast instead [cppcoreguidelines-pro-type-static-cast-downcast,-warnings-as-errors]
PWGDQ/Tasks/tableReader_withAssoc.cxx:717:30: error: do not use static_cast to downcast from a base to a derived class; use dynamic_cast instead [cppcoreguidelines-pro-type-static-cast-downcast,-warnings-as-errors]
PWGDQ/Tasks/tableReader_withAssoc.cxx:986:29: error: do not use static_cast to downcast from a base to a derived class; use dynamic_cast instead [cppcoreguidelines-pro-type-static-cast-downcast,-warnings-as-errors]
PWGDQ/Tasks/tableReader_withAssoc.cxx:1932:5: error: use auto when initializing with a cast to avoid duplicating the type name [modernize-use-auto,-warnings-as-errors]
PWGDQ/Tasks/tableReader_withAssoc.cxx:3253:29: error: do not use static_cast to downcast from a base to a derived class; use dynamic_cast instead [cppcoreguidelines-pro-type-static-cast-downcast,-warnings-as-errors]
PWGDQ/Tasks/tableReader_withAssoc.cxx:3544:9: error: use auto when initializing with a cast to avoid duplicating the type name [modernize-use-auto,-warnings-as-errors]
PWGDQ/Tasks/tableReader_withAssoc.cxx:3545:9: error: use auto when initializing with a cast to avoid duplicating the type name [modernize-use-auto,-warnings-as-errors]
PWGDQ/Tasks/tableReader_withAssoc.cxx:3744:5: error: use auto when initializing with a cast to avoid duplicating the type name [modernize-use-auto,-warnings-as-errors]
PWGDQ/Tasks/tableReader_withAssoc.cxx:3745:5: error: use auto when initializing with a cast to avoid duplicating the type name [modernize-use-auto,-warnings-as-errors]
PWGDQ/Tasks/tableReader_withAssoc.cxx:4226:5: error: use auto when initializing with a template cast to avoid duplicating the type name [modernize-use-auto,-warnings-as-errors]
PWGDQ/Tasks/tableReader_withAssoc.cxx:4595:19: error: implicit conversion 'uint32_t' (aka 'unsigned int') -> 'bool' [readability-implicit-bool-conversion,-warnings-as-errors]
PWGDQ/Tasks/tableReader_withAssoc.cxx:4643:19: error: implicit conversion 'uint32_t' (aka 'unsigned int') -> 'bool' [readability-implicit-bool-conversion,-warnings-as-errors]
++ [[ 0 -gt 0 ]]
++ [[ 14 -gt 0 ]]
++ exit 1
--

Full log here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Development

Successfully merging this pull request may close these issues.

3 participants