[PWGJE] Add a new producer in PWGJE - #17400
Merged
Merged
Conversation
This commit introduces the QuarkGluonJetsProducer, which produces a self-contained quark/gluon jet ML skim from jet event data. It includes configurable parameters for event selections, jet properties, and particle identification methods.
mulewicz
requested review from
alibuild,
fjonasALICE,
jaimenorman,
mhemmer-cern and
nzardosh
as code owners
August 10, 2026 16:20
|
O2 linter results: ❌ 1 errors, |
github-actions
Bot
changed the title
nzardosh
reviewed
Aug 12, 2026
| } | ||
|
|
||
| DECLARE_SOA_TABLE(QGMLJets, "AOD", "QGMLJETS", | ||
| qgmljet::EventId, |
Collaborator
There was a problem hiding this comment.
why do you save event and jet Id? when the merger tool runs it will make these tables obsolete unless you use specific index coloumns. However in that case they should be pointing to other tables
| namespace qgmlconst | ||
| { | ||
| DECLARE_SOA_COLUMN(EventId, eventId, uint64_t); | ||
| DECLARE_SOA_COLUMN(JetId, jetId, uint64_t); |
Collaborator
There was a problem hiding this comment.
this should be an index coloumn pointing to the QGMLJets table
| return result; | ||
| } | ||
|
|
||
| int getJetMcCollisionId(ChargedMCDJets::iterator const& jet) |
Collaborator
There was a problem hiding this comment.
its better to instead do the following:
jet.collision_as().mcCollisionId()
instead of looping through tracks. Also in case of reassociation of track to events you might get a different collision Id
| static_cast<float>(dR), | ||
| jet.pt() > 0.f ? static_cast<float>(track.pt() / jet.pt()) : 0.f, | ||
| track.sign(), | ||
| static_cast<uint8_t>(passes), |
Collaborator
There was a problem hiding this comment.
why do you convert the bool to an int8 here? Also why even save the tracks that dont pass the track selection?
| track.hasTOF() ? static_cast<float>(track.tofNSigmaKa()) : missingTOF, | ||
| track.hasTOF() ? static_cast<float>(track.tofNSigmaPr()) : missingTOF, | ||
| track.hasTOF() ? static_cast<float>(track.beta()) : missingTOF, | ||
| static_cast<uint8_t>(pid.isPion), |
Collaborator
There was a problem hiding this comment.
why do you save both this and the tof Nsigma above?
Contributor
Author
There was a problem hiding this comment.
The foundation model I started working with uses these PID-derived features as inputs, so I initially wanted to preserve them in the producer. At the same time, I also wanted to keep the lower-level PID observables so I could later study which feature representation works best. However, I agree that the derived flags can be removed from the producer and recreated later in the data loader/preprocessing.
| } | ||
| } | ||
|
|
||
| qgMLJets( |
Collaborator
There was a problem hiding this comment.
write this table out before the track table so you can use its lastIndex() in the track table
Collaborator
|
Thanks for the PR @mulewicz . I have left some comments for you. Also does this build locally for you? I am surprised since the file is not appended with .cxx |
vkucera
previously requested changes
Aug 12, 2026
| WorkflowSpec defineDataProcessing(ConfigContext const& cfgc) | ||
| { | ||
| return WorkflowSpec{ | ||
| adaptAnalysisTask<QuarkGluonJetsProducer>(cfgc, TaskName{"quark-gluon-jets-producer"})}; |
| COMPONENT_NAME Analysis) | ||
|
|
||
| o2physics_add_dpl_workflow(quark-gluon-jets-producer | ||
| SOURCES quarkGluonJetsProducer.cxx |
vkucera
marked this pull request as draft
August 12, 2026 12:32
mulewicz
marked this pull request as ready for review
August 13, 2026 06:10
nzardosh
requested changes
Aug 18, 2026
| DECLARE_SOA_COLUMN(NConstituents, nConstituents, int32_t); | ||
| } // namespace qgmljet | ||
|
|
||
| DECLARE_SOA_TABLE(QGMLJets, "AOD", "QGMLJETS", |
Collaborator
There was a problem hiding this comment.
this table does not have a self index coloumn
o2::soa::Index<>
I am not sure if its needed if you want to index on it or if its just needed for the globalIndex() call but add it anyways
nzardosh
self-requested a review
August 18, 2026 10:39
nzardosh
approved these changes
Aug 18, 2026
nzardosh
enabled auto-merge (squash)
August 18, 2026 10:40
nzardosh
disabled auto-merge
August 18, 2026 10:43
nzardosh
enabled auto-merge (squash)
August 18, 2026 10:44
Collaborator
|
Error while checking build/O2Physics/code-check for 3f54b4d at 2026-08-18 17:46: Full log here. |
Collaborator
|
@mulewicz Please fix the errors at your earliest convenience. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The new producer will provide data to develop a machine learning jet tagger by fine-tuning the OmniLearn foundation model.