Skip to content

[PWGLF] Change the type of the efficiency histogram in hStrangeCorrelation.cxx - #17632

Merged
romainschotter merged 1 commit into
AliceO2Group:masterfrom
gengjiabin12:master
Aug 27, 2026
Merged

[PWGLF] Change the type of the efficiency histogram in hStrangeCorrelation.cxx#17632
romainschotter merged 1 commit into
AliceO2Group:masterfrom
gengjiabin12:master

Conversation

@gengjiabin12

Copy link
Copy Markdown
Contributor

No description provided.

@github-actions github-actions Bot added the pwglf label Aug 27, 2026
@github-actions github-actions Bot changed the title Change the type of the efficiency histogram in hStrangeCorrelation.cxx [PWGLF] Change the type of the efficiency histogram in hStrangeCorrelation.cxx Aug 27, 2026
@github-actions

Copy link
Copy Markdown

O2 linter results: ❌ 12 errors, ⚠️ 2 warnings, 🔕 0 disabled

@romainschotter
romainschotter enabled auto-merge (squash) August 27, 2026 10:19
@alibuild

Copy link
Copy Markdown
Collaborator

Error while checking build/O2Physics/code-check for d3f0128 at 2026-08-27 16:16:

## sw/BUILD/O2Physics-code-check-latest/log
--
========== List of issues found ==========
++ echo 'Found 4 errors and 57 warnings.'
Found 4 errors and 57 warnings.
++ [[ 4 -gt 0 ]]
++ cat /sw/BUILD/ecf499eb59de34c98d60df11d10e5376e5ad8a38/O2Physics-code-check/errors.txt
PWGLF/Tasks/Strangeness/hStrangeCorrelation.cxx:98:8: error: constructor does not initialize these fields: ccdb, pdgDB [cppcoreguidelines-pro-type-member-init,-warnings-as-errors]
PWGLF/Tasks/Strangeness/hStrangeCorrelation.cxx:817:5: error: Variable 'radius' with floating point type 'double' should not be used as a loop counter [clang-analyzer-security.FloatLoopCounter,-warnings-as-errors]
PWGLF/Tasks/Strangeness/hStrangeCorrelation.cxx:1193:5: error: Variable 'r' with floating point type 'double' should not be used as a loop counter [clang-analyzer-security.FloatLoopCounter,-warnings-as-errors]
PWGLF/Tasks/Strangeness/hStrangeCorrelation.cxx:5210:9: error: uninitialized record type: 'triggerStageFills' [cppcoreguidelines-pro-type-member-init,-warnings-as-errors]
++ [[ 57 -gt 0 ]]
++ cat /sw/BUILD/ecf499eb59de34c98d60df11d10e5376e5ad8a38/O2Physics-code-check/warnings.txt
PWGLF/Tasks/Strangeness/hStrangeCorrelation.cxx:1623:75: warning: use designated initializer list to initialize 'PairLossPairKey' [modernize-use-designated-initializers]
PWGLF/Tasks/Strangeness/hStrangeCorrelation.cxx:3200:9: warning: the 'empty' method should be used to check for emptiness instead of comparing to an empty object [readability-container-size-empty]
PWGLF/Tasks/Strangeness/hStrangeCorrelation.cxx:3378:9: warning: the 'empty' method should be used to check for emptiness instead of 'size' [readability-container-size-empty]
PWGLF/Tasks/Strangeness/hStrangeCorrelation.cxx:3620:9: warning: the 'empty' method should be used to check for emptiness instead of 'size' [readability-container-size-empty]
PWGLF/Tasks/Strangeness/hStrangeCorrelation.cxx:3657:9: warning: the 'empty' method should be used to check for emptiness instead of 'size' [readability-container-size-empty]
PWGLF/Tasks/Strangeness/hStrangeCorrelation.cxx:3812:9: warning: the 'empty' method should be used to check for emptiness instead of 'size' [readability-container-size-empty]
PWGLF/Tasks/Strangeness/hStrangeCorrelation.cxx:3897:11: warning: the 'empty' method should be used to check for emptiness instead of 'size' [readability-container-size-empty]
PWGLF/Tasks/Strangeness/hStrangeCorrelation.cxx:3954:13: warning: the 'empty' method should be used to check for emptiness instead of 'size' [readability-container-size-empty]
PWGLF/Tasks/Strangeness/hStrangeCorrelation.cxx:4013:13: warning: the 'empty' method should be used to check for emptiness instead of 'size' [readability-container-size-empty]
PWGLF/Tasks/Strangeness/hStrangeCorrelation.cxx:4063:11: warning: the 'empty' method should be used to check for emptiness instead of 'size' [readability-container-size-empty]
PWGLF/Tasks/Strangeness/hStrangeCorrelation.cxx:4166:13: warning: the 'empty' method should be used to check for emptiness instead of 'size' [readability-container-size-empty]
PWGLF/Tasks/Strangeness/hStrangeCorrelation.cxx:4196:9: warning: the 'empty' method should be used to check for emptiness instead of 'size' [readability-container-size-empty]
PWGLF/Tasks/Strangeness/hStrangeCorrelation.cxx:4429:15: warning: boolean expression can be simplified by DeMorgan's theorem [readability-simplify-boolean-expr]
PWGLF/Tasks/Strangeness/hStrangeCorrelation.cxx:4431:41: warning: use 'contains' to check for membership [readability-container-contains]
PWGLF/Tasks/Strangeness/hStrangeCorrelation.cxx:4468:36: warning: use 'contains' to check for membership [readability-container-contains]
PWGLF/Tasks/Strangeness/hStrangeCorrelation.cxx:4520:15: warning: boolean expression can be simplified by DeMorgan's theorem [readability-simplify-boolean-expr]
PWGLF/Tasks/Strangeness/hStrangeCorrelation.cxx:4522:30: warning: redundant explicit casting to the same type 'int64_t' (aka 'long') as the sub-expression, remove this casting [readability-redundant-casting]
PWGLF/Tasks/Strangeness/hStrangeCorrelation.cxx:4536:26: warning: redundant explicit casting to the same type 'int64_t' (aka 'long') as the sub-expression, remove this casting [readability-redundant-casting]
PWGLF/Tasks/Strangeness/hStrangeCorrelation.cxx:4547:28: warning: redundant explicit casting to the same type 'int64_t' (aka 'long') as the sub-expression, remove this casting [readability-redundant-casting]
PWGLF/Tasks/Strangeness/hStrangeCorrelation.cxx:4621:13: warning: the 'empty' method should be used to check for emptiness instead of 'size' [readability-container-size-empty]
PWGLF/Tasks/Strangeness/hStrangeCorrelation.cxx:4625:31: warning: the 'empty' method should be used to check for emptiness instead of 'size' [readability-container-size-empty]
PWGLF/Tasks/Strangeness/hStrangeCorrelation.cxx:4739:26: warning: redundant explicit casting to the same type 'int64_t' (aka 'long') as the sub-expression, remove this casting [readability-redundant-casting]
PWGLF/Tasks/Strangeness/hStrangeCorrelation.cxx:4740:30: warning: redundant explicit casting to the same type 'int64_t' (aka 'long') as the sub-expression, remove this casting [readability-redundant-casting]
PWGLF/Tasks/Strangeness/hStrangeCorrelation.cxx:4741:30: warning: redundant explicit casting to the same type 'int64_t' (aka 'long') as the sub-expression, remove this casting [readability-redundant-casting]
PWGLF/Tasks/Strangeness/hStrangeCorrelation.cxx:4764:32: warning: use 'contains' to check for membership [readability-container-contains]
PWGLF/Tasks/Strangeness/hStrangeCorrelation.cxx:4817:61: warning: use designated initializer list to initialize 'PairLossFinalRecord' [modernize-use-designated-initializers]
PWGLF/Tasks/Strangeness/hStrangeCorrelation.cxx:4818:32: warning: use designated initializer list to initialize 'PairLossPairKey' [modernize-use-designated-initializers]
PWGLF/Tasks/Strangeness/hStrangeCorrelation.cxx:4934:26: warning: redundant explicit casting to the same type 'int64_t' (aka 'long') as the sub-expression, remove this casting [readability-redundant-casting]
PWGLF/Tasks/Strangeness/hStrangeCorrelation.cxx:4948:11: warning: redundant explicit casting to the same type 'int64_t' (aka 'long') as the sub-expression, remove this casting [readability-redundant-casting]
PWGLF/Tasks/Strangeness/hStrangeCorrelation.cxx:4982:26: warning: redundant explicit casting to the same type 'int64_t' (aka 'long') as the sub-expression, remove this casting [readability-redundant-casting]
PWGLF/Tasks/Strangeness/hStrangeCorrelation.cxx:4999:15: warning: use auto when initializing with a cast to avoid duplicating the type name [modernize-use-auto]
PWGLF/Tasks/Strangeness/hStrangeCorrelation.cxx:4999:42: warning: redundant explicit casting to the same type 'int64_t' (aka 'long') as the sub-expression, remove this casting [readability-redundant-casting]
PWGLF/Tasks/Strangeness/hStrangeCorrelation.cxx:5046:28: warning: redundant explicit casting to the same type 'int64_t' (aka 'long') as the sub-expression, remove this casting [readability-redundant-casting]
PWGLF/Tasks/Strangeness/hStrangeCorrelation.cxx:5047:32: warning: redundant explicit casting to the same type 'int64_t' (aka 'long') as the sub-expression, remove this casting [readability-redundant-casting]
PWGLF/Tasks/Strangeness/hStrangeCorrelation.cxx:5048:32: warning: redundant explicit casting to the same type 'int64_t' (aka 'long') as the sub-expression, remove this casting [readability-redundant-casting]
PWGLF/Tasks/Strangeness/hStrangeCorrelation.cxx:5106:28: warning: redundant explicit casting to the same type 'int64_t' (aka 'long') as the sub-expression, remove this casting [readability-redundant-casting]
[0 more errors; see full log]

Full log here.

@romainschotter
romainschotter merged commit f6e7dc5 into AliceO2Group:master Aug 27, 2026
21 of 24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Development

Successfully merging this pull request may close these issues.

3 participants