[OGUI-1903] Fix multiline select and copying - #3582
Merged
isaachilly merged 4 commits intoAug 24, 2026
Merged
Conversation
isaachilly
changed the title
isaachilly
force-pushed
the
bug/ILG/OGUI-1903/Copy-select-has-new-lines-issue
branch
2 times, most recently
from
August 21, 2026 09:28
6dbe66d to
46d41a4
Compare
Simplifies log cell markup by removing `.cell-content` and `.cell-text` wrappers so text sits directly in `<td>`, avoiding extra line breaks when copying multi-row selections. Thus updates `.cell` styling to handle truncation directly and repositions the context-menu hint as an absolute, non-selectable overlay so it doesn't get copied.
Add new test covering bug. Extract shared Puppeteer log/table helpers into a reusable test utility. Update context-menu assertions to read cell text from `td.cell`.
isaachilly
force-pushed
the
bug/ILG/OGUI-1903/Copy-select-has-new-lines-issue
branch
from
August 21, 2026 15:10
46d41a4 to
42300a4
Compare
isaachilly
marked this pull request as ready for review
August 21, 2026 15:12
graduta
approved these changes
Aug 24, 2026
graduta
left a comment
graduta
left a comment
Member
There was a problem hiding this comment.
Nicely done. For the future PRs, please make sure you add a description to the ticket.
For this particular change, it would have been good to add an example of description of the reported user bug.
isaachilly
deleted the
bug/ILG/OGUI-1903/Copy-select-has-new-lines-issue
branch
August 24, 2026 15:37
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I have JIRA issue created
Bug: Following the introduction of menu per cell, users now cannot copy by click + select entire rows of logs because the new divs (for menu item) are copying the cells with a new line as separator