Fix ALTS test provisioning: VM checkout cleanup and Alpine 3.22 apk-tools install#218
Merged
Conversation
The test repo is cloned to a persistent path on nebula VMs and reused across runs, so a previous checkout plus the test run leaves the tree dirty. The subsequent 'git checkout master'/'git checkout FETCH_HEAD' then aborts on local changes and untracked working-tree files. - prepare_gerrit_command: prefix every ref with 'git reset --hard && git clean -fdx' - GenericVMRunner.clone_third_party_repo: clean the reused checkout before switching refs (covers non-gerrit refs too) - add unit tests for prepare_gerrit_command
apk-tools-2.14.10-r100 depends on so:libapk.so.2.14.10 (libapk2), which is not installed during Alpine 3.22 provisioning. --no-network prevents apk from fetching it, so the offline install fails and initial_provision breaks for every Alpine 3.22 x86_64 test. Drop --no-network (keep --allow-untrusted) so apk can pull the dependency; the package is still passed as an explicit local file.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.