Repository navigation
Remove FUSERMOUNT_PROG logic - #158
Open
Skyb0rg007 wants to merge 1 commit into
Open
Skyb0rg007 wants to merge 1 commit into
Skyb0rg007 wants to merge 1 commit into
Conversation
Libfuse already tries /usr/bin/fusermount3, falling back to using $PATH. This removes the environment variable override logic. Fixes AppImage#150
Skyb0rg007
force-pushed
the
remove-fusermountPath
branch
from
October 18, 2026 03:48
ba8cff6 to
83ae8e8
Compare
Member
|
Thanks for your suggestion @Skyb0rg007. This needs very careful review and consideration. Might take some time. |
|
Build for testing: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Libfuse already tries /usr/bin/fusermount3, falling back to using $PATH. This removes the environment variable override logic.
This undoes #82.
Looking into why #82 was done, it mentions bug reports #15, #16, #31, #32, #35, #36, #37
#15,#16 was caused by AppImage's
access()check, so removing the logic does not affect it.#31 references probonopd/go-appimage#281, which is asking for
fusermount3to be searched on$PATH, which libfuse already did before you patched it out.#32 seems to have a discussion on why
execpshould be used, which wasn't resolved.#35,#36,#37 are bugs introduced by attempting to patch libfuse. By removing the patch, this isn't a concern.
As mentioned here, this also safeguards against a future
libfuserelease that creates a/usr/bin/fusermount4setuid binary. If that happens, distributions may make/usr/bin/fusermount3into a symlink (as Debian currently does with/usr/bin/fusermount -> /usr/bin/fusermount3).Another possibility is that a future libfuse version introduces a backwards-incompatible setuid binary format. If that happens, distributions may install a non-setuid
/usr/bin/fusermount3binary that translates between the two protocols.By removing the setuid check, AppImage becomes more robust to those possible future changes.
Replaces #151
Fixes #150