Skip to content

fix(pack): use before_init for schemastore jsonls/yamlls - #1789

Open
syltharion wants to merge 1 commit into
AstroNvim:mainfrom
syltharion:fix/schemastore-before-init
Open

fix(pack): use before_init for schemastore jsonls/yamlls#1789
syltharion wants to merge 1 commit into
AstroNvim:mainfrom
syltharion:fix/schemastore-before-init

Conversation

@syltharion

Copy link
Copy Markdown
Contributor

Closes #1774

Replaces on_new_config with before_init for schemastore integration in jsonls and yamlls configs. vim.lsp.config does not support on_new_config (neovim/neovim#32287). Adds nil guards matching the pattern used by basedpyright and vue packs.

Closes AstroNvim#1774

vim.lsp.config does not support on_new_config (neovim/neovim#32287).
Switch to before_init with nil guards, matching the pattern used by
basedpyright and vue packs.
@github-actions

Copy link
Copy Markdown

Review Checklist

Does this PR follow the [Contribution Guidelines](development guidelines)? Following is a partial checklist:

Proper conventional commit scoping:

  • If you are adding a new plugin, the scope would be the name of the category it is being added into. ex. feat(utility): added noice.nvim plugin

  • If you are modifying a pre-existing plugin or pack, the scope would be the name of the plugin folder. ex. fix(noice-nvim): fix LSP handler error

  • Pull request title has the appropriate conventional commit type and scope where the scope is the name of the pre-existing directory in the project as described above

  • README is properly formatted and uses fenced in links with <url> unless they are inside a [title](url)

  • Entry returns a single plugin spec with the new plugin as the only top level spec (not applicable for recipes or packs).

  • Proper usage of opts table rather than setting things up with the config function.

  • Proper usage of specs table for all specs that are not dependencies of a given plugin (not applicable for recipes or packs).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

schemastore not loaded jsonls/yamlls

1 participant