feat: switch index respects active filter#30
Merged
Palanikannan1437 merged 1 commit intoAtaraxy-Labs:mainfrom Apr 21, 2026
Merged
feat: switch index respects active filter#30Palanikannan1437 merged 1 commit intoAtaraxy-Labs:mainfrom
Palanikannan1437 merged 1 commit intoAtaraxy-Labs:mainfrom
Conversation
There was a problem hiding this comment.
inspect review
Triage: 1 entities analyzed | 0 critical, 0 high, 0 medium, 1 low
Verdict: standard_review
Findings (1)
- [low] The comment says the "running" filter should include only sessions where an agent is currently running, but the implementation also includes status === "waiting" (and "tool-running"). Including "waiting" contradicts the stated semantics and will misclassify non-running sessions as running.
Evidence in diff:
// "running" — only sessions where an agent is currently running
return st === "running" || st === "tool-running" || st === "waiting";
Reviewed by inspect | Entity-level triage found 0 high-risk changes
Contributor
|
thanks @cperalt for the pr! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #29