Skip to content

feat: switch index respects active filter#30

Merged
Palanikannan1437 merged 1 commit intoAtaraxy-Labs:mainfrom
cperalt:fix/switch-index-filter
Apr 21, 2026
Merged

feat: switch index respects active filter#30
Palanikannan1437 merged 1 commit intoAtaraxy-Labs:mainfrom
cperalt:fix/switch-index-filter

Conversation

@cperalt
Copy link
Copy Markdown
Contributor

@cperalt cperalt commented Apr 20, 2026

Closes #29

Copy link
Copy Markdown

@inspect-review inspect-review bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

inspect review

Triage: 1 entities analyzed | 0 critical, 0 high, 0 medium, 1 low
Verdict: standard_review

Findings (1)

  1. [low] The comment says the "running" filter should include only sessions where an agent is currently running, but the implementation also includes status === "waiting" (and "tool-running"). Including "waiting" contradicts the stated semantics and will misclassify non-running sessions as running.
    Evidence in diff:
    // "running" — only sessions where an agent is currently running
    return st === "running" || st === "tool-running" || st === "waiting";

Reviewed by inspect | Entity-level triage found 0 high-risk changes

@Palanikannan1437
Copy link
Copy Markdown
Contributor

thanks @cperalt for the pr!

@Palanikannan1437 Palanikannan1437 merged commit 06d56cb into Ataraxy-Labs:main Apr 21, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

switch-index ignores active sessions filter

2 participants