chore(sequencer): e2e tests for invalid signature recovery in checkpoint attestations#20971
Open
spalladino wants to merge 1 commit intomerge-train/spartanfrom
Open
chore(sequencer): e2e tests for invalid signature recovery in checkpoint attestations#20971spalladino wants to merge 1 commit intomerge-train/spartanfrom
spalladino wants to merge 1 commit intomerge-train/spartanfrom
Conversation
…nt attestations Adds end-to-end tests covering A-71: ensuring nodes correctly detect and invalidate checkpoints with malleable (high-s value) or unrecoverable attestation signatures. Also refactors the invalidate block test suite to reduce code duplication via shared helpers. - Add `injectHighSValueAttestation` and `injectUnrecoverableSignatureAttestation` sequencer config options for testing - Update `Signature.random()` to produce valid ECDSA signatures with low s-values - Add `generateRecoverableSignature` and `generateUnrecoverableSignature` utilities - Refactor e2e invalidate block tests with `runDoubleInvalidationTest` and `runSingleInvalidationTest` helpers - Add unit tests for high-s validation, signature utilities, and Signature.random() Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
spalladino
changed the title
Collaborator
Flakey Tests🤖 says: This CI run detected 1 tests that failed, but were tolerated due to a .test_patterns.yml entry. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Test that high-s or invalid ECDSA signatures posted by a malicious proposer can be properly invalidated.
Summary
injectHighSValueAttestationandinjectUnrecoverableSignatureAttestationsequencer config options for testingSignature.random()to produce valid ECDSA signatures with low s-valuesgenerateRecoverableSignature/generateUnrecoverableSignatureutilities with unit testsFixes A-71
Test plan
Signature.random()validity,generateRecoverableSignature,generateUnrecoverableSignature, high-s validation🤖 Generated with Claude Code